Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature of KeywordList constructor is not enforced #4510

Closed
morozov opened this issue Feb 26, 2021 · 1 comment · Fixed by #4587, #4547, #4583 or #4597
Closed

Signature of KeywordList constructor is not enforced #4510

morozov opened this issue Feb 26, 2021 · 1 comment · Fixed by #4587, #4547, #4583 or #4597
Labels
Reserved Keywords Static Analysis
Milestone
4.0.0-beta1

Comments

@morozov
Copy link
Member

morozov commented Feb 26, 2021

Psalm on level 2:

ERROR: UnsafeInstantiation - lib/Doctrine/DBAL/Tools/Console/Command/ReservedWordsCommand.php:192:27 - Cannot safely instantiate class Doctrine\DBAL\Platforms\Keywords\KeywordList with "new $class_name" as its constructor might change in child classes (see https://psalm.dev/229)
            $keywords[] = new $class();
@morozov morozov changed the title Signature of KeywordList lists is not enforced Signature of KeywordList constructor is not enforced Feb 26, 2021
@morozov morozov mentioned this issue Mar 15, 2021
Merged
morozov added a commit to morozov/dbal that referenced this issue Apr 1, 2021
@morozov
[doctrineGH-4510] Trigger deprecation in AbstractPlatform::getReserve…
a602f2b 
…dKeywordsClass() implementations
@morozov morozov added this to the 4.0.0 milestone Apr 2, 2021
morozov added a commit to morozov/dbal that referenced this issue Apr 3, 2021
@morozov
[doctrineGH-4510] Remove AbstractPlatform::getReservedKeywordsClass()
02dbdd0
morozov added a commit to morozov/dbal that referenced this issue Apr 3, 2021
@morozov
[doctrineGH-4510] Remove AbstractPlatform::getReservedKeywordsClass()
b62fe1b
@morozov morozov mentioned this issue Apr 3, 2021
Merged
morozov added a commit that referenced this issue Apr 4, 2021
@morozov
Merge pull request #4583 from morozov/issues/4510
461b3b7 
[GH-4510] Remove AbstractPlatform::getReservedKeywordsClass()
morozov added a commit to morozov/dbal that referenced this issue Apr 4, 2021
@morozov
[doctrineGH-4510] Deprecate ReservedWordsCommand::setKeywordListClass()
926c1c3
morozov added a commit to morozov/dbal that referenced this issue Apr 4, 2021
@morozov
[doctrineGH-4510] Deprecate ReservedWordsCommand::setKeywordListClass()
ee22503
@morozov morozov mentioned this issue Apr 4, 2021
Merged
This was linked to pull requests Apr 4, 2021
[GH-4510] Deprecate ReservedWordsCommand::setKeywordListClass() #4587
Merged
Deprecate AbstractPlatform::getReservedKeywordsClass() #4547
Merged
[GH-4510] Remove AbstractPlatform::getReservedKeywordsClass() #4583
Merged
morozov added a commit that referenced this issue Apr 5, 2021
@morozov
Merge pull request #4587 from morozov/issues/4510
5fb6543 
[GH-4510] Deprecate ReservedWordsCommand::setKeywordListClass()
morozov added a commit to morozov/dbal that referenced this issue Apr 10, 2021
@morozov
[doctrineGH-4510] Remove ReservedWordsCommand::setKeywordListClass()
5e9c74c
@morozov morozov mentioned this issue Apr 10, 2021
Merged
morozov added a commit that referenced this issue Apr 10, 2021
@morozov
Merge pull request #4597 from morozov/issues/4510
88198d6 
[GH-4510] Remove ReservedWordsCommand::setKeywordListClass()
@morozov morozov mentioned this issue Feb 18, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Reserved Keywords Static Analysis
Projects
None yet
Milestone
4.0.0-beta1
1 participant
@morozov