Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4510] Remove ReservedWordsCommand::setKeywordListClass() #4597

Merged
merged 1 commit into from Apr 10, 2021
Merged

[GH-4510] Remove ReservedWordsCommand::setKeywordListClass() #4597

merged 1 commit into from Apr 10, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 10, 2021

Q A
Type improvement
BC Break yes

Closes #4510.

@morozov morozov added this to the 4.0.0 milestone Apr 10, 2021
@morozov morozov marked this pull request as ready for review April 10, 2021 04:34
@morozov morozov requested a review from greg0ire April 10, 2021 04:34
@morozov morozov merged commit 88198d6 into doctrine:4.0.x Apr 10, 2021
@morozov morozov deleted the issues/4510 branch April 10, 2021 14:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Reserved Keywords
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Signature of KeywordList constructor is not enforced
2 participants
@morozov @greg0ire