Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractPlatform::getReservedKeywordsClass() #4547

Merged
merged 1 commit into from Mar 17, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 15, 2021

Q A
Type deprecation

See #4510. With the new API, each platform will be responsible for instantiating its keyword list, so there will be no need to enforce the constructor signature.

@morozov morozov added this to the 3.1.0 milestone Mar 15, 2021
@morozov morozov requested a review from greg0ire March 15, 2021 18:56
@morozov morozov marked this pull request as ready for review March 16, 2021 16:57
@morozov morozov requested review from greg0ire and removed request for greg0ire March 17, 2021 15:09
@morozov morozov merged commit 4fa884c into doctrine:3.1.x Mar 17, 2021
@morozov morozov deleted the issues/4510 branch March 17, 2021 19:34
@morozov morozov linked an issue Apr 4, 2021 that may be closed by this pull request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature of KeywordList constructor is not enforced
2 participants