Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4510] Remove AbstractPlatform::getReservedKeywordsClass() #4583

Merged
merged 1 commit into from Apr 4, 2021
Merged

[GH-4510] Remove AbstractPlatform::getReservedKeywordsClass() #4583

merged 1 commit into from Apr 4, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 3, 2021

Q A
Type improvement
BC Break yes

See #4510.

@morozov morozov added this to the 4.0.0 milestone Apr 3, 2021
@morozov morozov marked this pull request as ready for review April 3, 2021 17:16
@morozov morozov requested a review from greg0ire April 3, 2021 17:16
@morozov morozov merged commit 461b3b7 into doctrine:4.0.x Apr 4, 2021
@morozov morozov deleted the issues/4510 branch April 4, 2021 14:14
@morozov morozov linked an issue Apr 4, 2021 that may be closed by this pull request
Signature of KeywordList constructor is not enforced #4510
Closed
@morozov morozov mentioned this pull request Dec 19, 2021
Merged
@morozov morozov mentioned this pull request Jan 6, 2022
Merged
@morozov morozov mentioned this pull request Feb 13, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Platforms Reserved Keywords
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Signature of KeywordList constructor is not enforced
2 participants
@morozov @greg0ire