Remove scalar bound from geometry type defs #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inconsistently applied, with some types having <T>, some having <T: Scalar>, and some having <T: RealField>. This unifies all types to match the convention of Matrix: Just declare <T> at type def time, and apply bounds on impls only. A significant advantage of this approach is const fn construction. Const fn generics currently still can't have trait bounds, so any generic const fn needs to only move opaque types around. Construction methods such as new_unchecked or from_parts can be made const by removing their generic bounds after this PR. Actual constification is left to a follow-up PR. Note that na::Transform is _not_ loosened here, as it has more complicated definition requirements.
|
Thank you for this PR! This is a good idea. I think the CI is failing when nalgebra is built with the |
|
That's what I get for not checking Should work now. |
|
I don't think that proptest failure is even possibly caused by my changes. |
|
Yeah, this happens from time to time if we are unlucky with the test inputs (and get a particularly badly conditioned matrix). |
|
It succeeds now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inconsistently applied, with some types having , some having
<T: Scalar>, and some having <T: RealField>.
This unifies all types to match the convention of Matrix:
Just declare at type def time, and apply bounds on impls only.
A significant advantage of this approach is const fn construction. Const
fn generics currently still can't have trait bounds, so any generic
const fn needs to only move opaque types around. Construction methods
such as new_unchecked or from_parts can be made const by removing their
generic bounds after this PR.
Actual constification is left to a follow-up PR.
Note that na::Transform is not loosened here, as it has more complicated
definition requirements.