Impl bytemuck traits for geometry types #925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds impls for
bytemuck::Zeroable
andbytemuck::Pod
to thena::geometry::*
types that don't already have them. All added impls just fully gate themselves on the fields' impls for these traits, so they should all be sound, unless I missed one of the following conditions:#[repr(C)]
or#[repr(transparent)]
; orT
or other type parameters)I believe this should reasonably close #830.