Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scalar bound from geometry type defs #932

Merged
merged 2 commits into from Jul 10, 2021
Merged

Commits on Jul 6, 2021

  1. Remove scalar bound from geometry type defs

    This was inconsistently applied, with some types having <T>, some having
    <T: Scalar>, and some having <T: RealField>.
    This unifies all types to match the convention of Matrix:
    Just declare <T> at type def time, and apply bounds on impls only.
    
    A significant advantage of this approach is const fn construction. Const
    fn generics currently still can't have trait bounds, so any generic
    const fn needs to only move opaque types around. Construction methods
    such as new_unchecked or from_parts can be made const by removing their
    generic bounds after this PR.
    
    Actual constification is left to a follow-up PR.
    
    Note that na::Transform is _not_ loosened here, as it has more complicated
    definition requirements.
    CAD97 committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    314b4dd View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. FIx serde impl bounds

    CAD97 committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    85d07b2 View commit details
    Browse the repository at this point in the history