Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.21.0-RC1 #4900

Merged
merged 8 commits into from Jun 2, 2022
Merged

Prepare 1.21.0-RC1 #4900

merged 8 commits into from Jun 2, 2022

Conversation

cortinico
Copy link
Member

Time to prepare a new release. This time it was harder than expected :(

  • d4fcd48 Had to make sure the Gradle Plugin has a valid POM, as we now publish it to Central as well. Without a valid pom the whole publishing can't be performed.
  • 87f32e1 Revert enabling MissingPackageDeclaration by default - See Active rules by default #4875
  • e79afd7 Fix InvalidPackageDeclaration on functionalTests - This is really concerning as it means that our functionalTest for the Gradle Plugin are still consuming a version from Maven Central are not effectively testing the latest changes on main (cc @3flex for visiblity).

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #4900 (a4d2d9f) into main (1258c2f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4900   +/-   ##
=========================================
  Coverage     84.82%   84.82%           
  Complexity     3494     3494           
=========================================
  Files           496      496           
  Lines         11515    11515           
  Branches       2130     2130           
=========================================
  Hits           9768     9768           
  Misses          686      686           
  Partials       1061     1061           
Impacted Files Coverage Δ
...sch/detekt/rules/bugs/MissingPackageDeclaration.kt 92.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1258c2f...a4d2d9f. Read the comment docs.

@cortinico
Copy link
Member Author

Can we merge this as I can't create a Tag/Github release otherwise?

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants