Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingPackageDeclaration not active since 1.21.0 #5268

Closed
mi0x opened this issue Sep 1, 2022 · 1 comment
Closed

MissingPackageDeclaration not active since 1.21.0 #5268

mi0x opened this issue Sep 1, 2022 · 1 comment
Labels

Comments

@mi0x
Copy link

mi0x commented Sep 1, 2022

Expected Behavior

Looking at the published changelogs of 1.21.0 it is mentioned that ~30 rules are now enabled by default.
When looking at the referred Pull Request (#4875) I see that the MissingPackageDeclaration rule is mentioned as one of those, however, is seems that it is not active by default when looking at the documentation (https://detekt.dev/docs/rules/potential-bugs/#missingpackagedeclaration) or trying it out by purposely violating the rule.

I want to make sure if this was reverted by accident or not.

Observed Behavior

The MissingPackageDeclaration rule is not active by default.

Steps to Reproduce

  • Configure to use the 1.21.0 version of Detekt
  • Delete the MissingPackageDeclaration from the Detekt configuration
  • Create a new class without declaring the package in the file
  • Run Detekt

Context

I was using the changelog to update our config files, I saw a mismatch between the information there and the information in the documentation.

Your Environment

  • Version of detekt used: 1.21.0
@mi0x mi0x added the bug label Sep 1, 2022
@3flex
Copy link
Member

3flex commented Sep 2, 2022

It wasn't enabled by default in the end, see #4900 & 87f32e1

I've updated the PR description in #4875 to reflect this - thanks for pointing this out!

@3flex 3flex closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants