Run functionalTest on MavenLocal

[cortinico]

This tries to address the problem I had in #4900

Essentially, our Gradle Plugin tests are currently running by fetching detekt-cli from Maven Central/Local. The problem is that once I bump the version and publishToMavenLocal during the release process, I'm effectivelly exposed to all the tests failures that got never reported on main as we're using a older version of detekt-cli.

With this PR, I'm bumping the version to use the "next", and forcing the build task to depend on publishToMavenLocal. This will make sure the Gradle Plugin tests on CI are effectively running on a locally crafted version of detekt-cli.

I agree that this is not idea, as we should instead inject the class-path, but this is better than the status quo. Looking for opinions.

To reproduce this:

• Add the @ActiveByDefault to the MissingPackageDeclaration rule
• Verify that tests are actually failing inside the Gradle Plugin
• Previously they were not (that's how Active rules by default #4875 got merged)

[codecov]

Codecov Report

Merging #4905 (8a88441) into main (ad9ef16) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4905   +/-   ##
=========================================
  Coverage     84.83%   84.83%           
  Complexity     3494     3494           
=========================================
  Files           496      496           
  Lines         11514    11514           
  Branches       2129     2129           
=========================================
  Hits           9768     9768           
  Misses          685      685           
  Partials       1061     1061           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9ef16...8a88441. Read the comment docs.

[cortinico]

Seems like we need to a task dependency between :detekt-cli:publishToMavenLocal and :detekt-gradle-plugin:test. Not sure we really want to go this way 🤔

[github-actions]

This PR is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

[cortinico]

Should we close this in favor of #5149 @3flex ?

[3flex]

I think so, if you're in general ok with that approach. I'll finish it off sometime soon I hope!