Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #220] Rename Datarockets::Style to DatarocketsStyle #240

Merged
merged 4 commits into from Feb 8, 2021
Merged

[Fix #220] Rename Datarockets::Style to DatarocketsStyle #240

merged 4 commits into from Feb 8, 2021

Conversation

paydaylight
Copy link
Contributor

@paydaylight paydaylight commented Feb 4, 2021 •
edited

  • Changed module Datarockets::Style to DatarocketsStyle
  • Moved lib/datarockets/style to lib/datarockets_style
  • Changed spec/datarockets/style to spec/datarockets_style
  • Fixed accompanying issues

Before you submit a pull request, please make sure you have to follow:

  • read and know items from the Contributing Guide
  • add a description of the problem you're trying to solve (short summary from related issue)
  • verified that cops are ordered by alphabet
  • add a note to the style guide docs (if it needs)
  • add a note to the changelog file
  • the commit message contains the number of the related issue (if it presents)
    and word Fix if this PR closes related issue
  • squash all commits before submitting to review

@paydaylight paydaylight changed the title Rename to datarockets style [Fix #220] Rename Datarockets::Style to DatarocketsStyle Feb 4, 2021
@paydaylight paydaylight linked an issue Feb 4, 2021 that may be closed by this pull request
Fix warnings #220
Closed
@paydaylight paydaylight merged commit 2701703 into master Feb 8, 2021
@paydaylight paydaylight deleted the rename_to_datarockets_style branch February 8, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-dubrovsky roman-dubrovsky roman-dubrovsky approved these changes

@nikitasakau nikitasakau Awaiting requested review from nikitasakau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warnings
2 participants
@paydaylight @roman-dubrovsky