Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #220

Closed
roman-dubrovsky opened this issue Nov 9, 2020 · 2 comments · Fixed by #240
Closed

Fix warnings #220

roman-dubrovsky opened this issue Nov 9, 2020 · 2 comments · Fixed by #240
Labels
bug Something isn't working refactoring Refactoring or other improvements which don't add new features
Milestone
1.2.0

Comments

@roman-dubrovsky
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After updating rubocop to 1.*.*, get the next warnings

config/base.yml: Layout/ArrayAlignmentExtended has the wrong namespace - should be Cop/Layout
config/base.yml: Style/NestedInterpolation has the wrong namespace - should be Cop/Style
@roman-dubrovsky roman-dubrovsky added bug Something isn't working refactoring Refactoring or other improvements which don't add new features labels Nov 9, 2020
@roman-dubrovsky roman-dubrovsky added this to the 1.1.0 milestone Nov 9, 2020
@roman-dubrovsky
Copy link
Contributor Author

This happens because of these changes rubocop/rubocop#8490

So this cop has the next class name Datarockets::Style::Cop::Style::NestedInterpolation, rubocop cut two first module and wants that name was Cop/Style/NestedInterpolation.

So easier way here, try to change modules Datarockets::Style to DatarocketsStyle. Also, we can try to path original logic, But I don't really want to do it. Do you have any thoughts?

@texpert
Copy link
Contributor

texpert commented Nov 10, 2020

Yeah, it seems easier and better to change our namespace.

paydaylight added a commit that referenced this issue Feb 4, 2021
@paydaylight
[Fix #220] changed namespace to DatarocketsStyle
e807668
@paydaylight paydaylight linked a pull request Feb 4, 2021 that will close this issue
[Fix #220] Rename Datarockets::Style to DatarocketsStyle #240
Merged
7 tasks
paydaylight added a commit that referenced this issue Feb 8, 2021
@paydaylight
[Fix #220] Rename Datarockets::Style to DatarocketsStyle (#240)
2701703 
* [Fix #220] changed namespace to DatarocketsStyle

* obey Layout/MultilineMethodCallIndentation cop

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working refactoring Refactoring or other improvements which don't add new features
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

[Fix #220] Rename Datarockets::Style to DatarocketsStyle datarockets/ruby-style
2 participants
@texpert @roman-dubrovsky