[Fix #220] Rename Datarockets::Style to DatarocketsStyle

CHANGELOG.md

@@ -4,6 +4,10 @@ The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-
 
 ## master
 
+## Changed
+
+* Change ```Datarockets::Style``` module to ```DatarocketsStyle``` ([@paydaylight](https://github.com/paydaylight))
+
 ## 1.0.1 (2021-02-04)
 
 ### Added

bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 require "bundler/setup"
-require "datarockets/style"
+require "datarockets_style"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

config/base.yml

@@ -1,4 +1,4 @@
-require: datarockets/style
+require: datarockets_style
 
 AllCops:
   NewCops: enable

datarockets-style.gemspec

@@ -1,10 +1,10 @@
 lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "datarockets/style/version"
+require "datarockets_style/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "datarockets-style"
-  spec.version       = Datarockets::Style::VERSION
+  spec.version       = DatarocketsStyle::VERSION
   spec.authors       = ["Roman Dubrovsky"]
   spec.email         = ["r.dubrovsky@datarockets.com"]
 

lib/datarockets_style.rb

@@ -0,0 +1,12 @@
+require "rubocop"
+require "datarockets_style/formatter/todo_list_formatter"
+
+require "datarockets_style/version"
+
+require "datarockets_style/cop/layout/array_alignment_extended"
+require "datarockets_style/cop/style/nested_interpolation"
+
+# Top level module for datarockets-style
+module DatarocketsStyle
+  # Datarickors sharable config
+end

lib/datarockets_style/cop/layout/array_alignment_extended.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+module DatarocketsStyle
+  module Cop
+    module Layout
+      # Here we check if the elements of a multi-line array literal are
+      # aligned.
+      #
+      # @example EnforcedStyle: with_first_argument (default)
+      #   # good
+      #
+      #   array = [1, 2, 3,
+      #            4, 5, 6]
+      #   array = ['run',
+      #            'forrest',
+      #            'run']
+      #
+      #   # bad
+      #
+      #   array = [1, 2, 3,
+      #     4, 5, 6]
+      #   array = ['run',
+      #        'forrest',
+      #        'run']
+      #
+      # @example EnforcedStyle: with_fixed_indentation
+      #   # good
+      #
+      #   array = [1, 2, 3,
+      #     4, 5, 6]
+      #
+      #   # bad
+      #
+      #   array = [1, 2, 3,
+      #            4, 5, 6]
+      class ArrayAlignmentExtended < RuboCop::Cop::Cop
+        include RuboCop::Cop::Alignment
+
+        ALIGN_PARAMS_MSG = "Align the elements of an array literal if they span more than one line."
+
+        FIXED_INDENT_MSG = "Use one level of indentation for elements " \
+            "following the first line of a multi-line array."
+
+        def on_array(node)
+          return if node.children.size < 2
+
+          check_alignment(node.children, base_column(node, node.children))
+        end
+
+        def autocorrect(node)
+          RuboCop::Cop::AlignmentCorrector.correct(processed_source, node, column_delta)
+        end
+
+        private
+
+        def message(_node)
+          fixed_indentation? ? FIXED_INDENT_MSG : ALIGN_PARAMS_MSG
+        end
+
+        def fixed_indentation?
+          cop_config["EnforcedStyle"] == "with_fixed_indentation"
+        end
+
+        def base_column(node, args)
+          fixed_indentation? ? line_indentation(node) : display_column(args.first.source_range)
+        end
+
+        def line_indentation(node)
+          lineno = target_method_lineno(node)
+          line = node.source_range.source_buffer.source_line(lineno)
+          line_indentation = /\S.*/.match(line).begin(0)
+          line_indentation + configured_indentation_width
+        end
+
+        def target_method_lineno(node)
+          node.loc.line
+        end
+      end
+    end
+  end
+end

lib/datarockets_style/cop/style/nested_interpolation.rb

@@ -0,0 +1,35 @@
+module DatarocketsStyle
+  module Cop
+    module Style
+      # This cop checks nested interpolations
+      #
+      # @example
+      #
+      # # bad
+      # "Hello, #{user.blank? ? 'guest' : "dear #{user.name}"}"
+      #
+      # # good
+      # user_name = user.blank? ? 'guest' : "dear #{user.name}"
+      # "Hello, #{user_name}"
+      class NestedInterpolation < RuboCop::Cop::Cop
+        include RuboCop::Cop::Interpolation
+
+        MSG = "Redundant nested interpolation.".freeze
+
+        def on_interpolation(node)
+          node.each_descendant(:dstr) do |descendant_node|
+            detect_double_interpolation(descendant_node)
+          end
+        end
+
+        private
+
+        def detect_double_interpolation(node)
+          node.each_child_node(:begin) do |begin_node|
+            add_offense(begin_node)
+          end
+        end
+      end
+    end
+  end
+end

lib/datarockets/style/formatter/todo_list_formatter.rb → lib/datarockets_style/formatter/todo_list_formatter.rb

@@ -46,6 +46,6 @@ def finished(inspected_files)
       @total_correctable_count)
     output.puts
 
-    Datarockets::Style::Formatter::TodoListFormatter::ReportSummary.new(offense_list).call(output)
+    DatarocketsStyle::Formatter::TodoListFormatter::ReportSummary.new(offense_list).call(output)
   end
 end