Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added cupy.format_float_positional #6308

Merged
merged 2 commits into from Jan 17, 2022
Merged

added cupy.format_float_positional #6308

merged 2 commits into from Jan 17, 2022

Conversation

amanchhaparia
Copy link
Contributor

Hello,
I recently came across the CUPY and found it interesting. I am excited and want to contribute to the cupy.

I have implement the cupy.format_float_positional as requested in #6078,
looking for a review and further guidance.

Thank you.

@kmaehashi kmaehashi mentioned this pull request Jan 13, 2022
Open
@emcastillo emcastillo added cat:feature New features/APIs prio:medium labels Jan 13, 2022
kmaehashi
kmaehashi requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cupy/_io/formatting.py Outdated Show resolved Hide resolved
cupy/_io/formatting.py Outdated Show resolved Hide resolved
docs/source/reference/io.rst Outdated Show resolved Hide resolved
tests/cupy_tests/io_tests/test_formatting.py Show resolved Hide resolved
@amanchhaparia
Copy link
Contributor Author

@kmaehashi , I had updated my PR with requested changes can u please review them. Thank You

@kmaehashi
Copy link
Member

/test mini

kmaehashi
kmaehashi approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@kmaehashi kmaehashi added this to the v11.0.0a1 milestone Jan 17, 2022
@kmaehashi kmaehashi merged commit 89ae0b1 into cupy:master Jan 17, 2022
@kmaehashi kmaehashi mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:feature New features/APIs prio:medium
Projects
None yet
Milestone
v11.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amanchhaparia @kmaehashi @emcastillo