New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker] Implement all numpy.*
APIs in CuPy
#6078
Comments
Hi @kmaehashi, I was wondering if other APIs for constant functions like NumPy Reference: https://numpy.org/devdocs/reference/constants.html. |
@khushi-411 Thanks for pull-requests! All constants are imported in CuPy 😄 |
There's a whole bunch of very questionable stuff here, including things that are deprecated. It does not make sense to me to add those. But rather than spend time arguing about that, let me just go work on a PR to remove them from NumPy:) |
Yeah some of the easy and very easy things read that way to me The medium & medium to hard seem ok though (with the exception of the typing stuff) The iterating functions (particularly on GPUs) I'm not sure about, but maybe Leo has thoughts there. Anything else stick out to you, Ralf? Does the above sound roughly correct to you or are there other things that stick out? |
@rgommers Could you list what is deprecated/inappropriate? I thought @kmaehashi has avoided listing them. |
With "typing stuff" do you mean the dtype-related functions (
That sounds about right. The All of the undocumented ones I'd like to get rid of in NumPy. |
Yeah exactly. Sorry that was vague |
|
@rgommers Thank you for all the information. I've removed deprecated ones from the list:
Also marked dtype-related functions as low priority as there's an ongoing discussion in NumPy. |
i also want to contribute in this library but when i seen this all issues are resolved so could you please assign me a tasks |
I've noticed that the automatic domain functions (numpy.emath.* or numpy.lib.scimath.*) seem to be missing from this. Is this a mistake, or are they not supposed to be supported? |
@Nordicus Yes it's just because I overlooked it, thanks for the catch! 😄 |
Hi team, I was looking into implementing |
@pri1311 Hi, I agree it should be that simple. |
hey @kmaehashi , I would like to work on |
Hi @rajveer43, sure go ahead. |
I know how to add that function but..can you tell the locations i.e. path..where it is needed to be added? I am getting confused actually! |
Implement GPU version of
numpy.*
functions incupy.*
namespace.This is a tracker issue that lists the remaining
numpy.*
APIs (see also: comparison table). I've categorized them based on difficulty so that new contributors can pick the right task. Your contribution is highly welcomed and appreciated!List of APIs
Very Easy
Easy
Medium
Medium to Hard
Low priority (iterator functions)
Low priority (help functions)
Low priority (internal functions)
Low priority (dtype APIs - need to filter types unsupported by CuPy)
Low priority (rarely used APIs)
Steps to Contribute
Fork and star ⭐ the CuPy repository 😉
Pick a function you want to work on. You can find the function in the NumPy API Reference to understand what should be implemented.
Implement a function in your branch. If you need help, join Gitter or just ask for help in this issue.
Don't forget to write a test code!
Build CuPy and run tests to confirm that the function runs fine:
pip install -e . && pytest tests/cupy_tests/PATH_TO_YOUR_TEST
See the Contribution Guide for details.
Submit a pull-request to the
main
branch.Note that you will need a GPU environment to develop CuPy.
See also:
scipy.*
APIs in CuPy #6324The text was updated successfully, but these errors were encountered: