Skip to content

Commit

Permalink
Merge pull request #6308 from amanchhaparia/new_api
Browse files Browse the repository at this point in the history
added `cupy.format_float_positional`
  • Loading branch information
kmaehashi committed Jan 17, 2022
2 parents 50ebca6 + acd58f5 commit 89ae0b1
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions cupy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ def result_type(*arrays_and_dtypes):
from cupy._io.formatting import array_repr # NOQA
from cupy._io.formatting import array_str # NOQA
from cupy._io.formatting import array2string # NOQA
from cupy._io.formatting import format_float_positional # NOQA

from cupy._io.text import savetxt # NOQA

Expand Down
11 changes: 11 additions & 0 deletions cupy/_io/formatting.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,14 @@ def array2string(a, *args, **kwargs):
"""
return numpy.array2string(cupy.asnumpy(a), *args, **kwargs)


def format_float_positional(x, *args, **kwargs):
"""Format a floating-point scalar as a decimal string in positional notation.
See :func:`numpy.format_float_positional` for the list of arguments.
.. seealso:: :func:`numpy.format_float_positional`
"""
return numpy.format_float_positional(cupy.asnumpy(x), *args, **kwargs)
1 change: 1 addition & 0 deletions docs/source/reference/io.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ String formatting
array2string
array_repr
array_str
format_float_positional


Base-n representations
Expand Down
11 changes: 11 additions & 0 deletions tests/cupy_tests/io_tests/test_formatting.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,14 @@ def test_array2string(self):
a = testing.shaped_arange((2, 3, 4), cupy)
b = testing.shaped_arange((2, 3, 4), numpy)
return cupy.array2string(a) == numpy.array2string(b)

def test_format_float_positional_python_scalar(self):
x = 1.0
assert cupy.format_float_positional(
x) == numpy.format_float_positional(x)

def test_format_float_positional(self):
a = testing.shaped_arange((1,), cupy)
b = testing.shaped_arange((1,), numpy)
assert cupy.format_float_positional(
a) == numpy.format_float_positional(b)

0 comments on commit 89ae0b1

Please sign in to comment.