Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix flake #696

Merged
merged 54 commits into from
Jan 18, 2023
Merged

Nix flake #696

merged 54 commits into from
Jan 18, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Jun 13, 2022

Add precommix for linting and formatting.

  • Provide a dev shell
  • Provide a nix package
  • Provide a nix flake
  • Fix CI
  • Document installation
  • Document hacking
  • Provide as much architectures as possible

docs/configuring.md Outdated Show resolved Hide resolved
yajo added a commit that referenced this pull request Jun 13, 2022
Fast-forward commitizen configuration from #696 to let me publish a new release with the changelog easily now.
@yajo yajo mentioned this pull request Jul 7, 2022
.editorconfig Show resolved Hide resolved
@yajo
Copy link
Member Author

yajo commented Aug 28, 2022

FTR I added a poll for Copier contributors in #757.

yajo added a commit that referenced this pull request Aug 28, 2022
pre-commit started failing with:

```
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment

more info:

virtualenv python version did not match created version:
- actual version: 3.10.6.final.0
- expected version: 3.10.4.final.0
```

Quick fix while #696 gets on track.

Sadly I had to rollback #752 due to PyCQA/isort#1945.
yajo added a commit that referenced this pull request Aug 28, 2022
pre-commit started failing with:

```
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment

more info:

virtualenv python version did not match created version:
- actual version: 3.10.6.final.0
- expected version: 3.10.4.final.0
```

Quick fix while #696 gets on track.

Sadly I had to rollback #752 due to PyCQA/isort#1945.
yajo added a commit that referenced this pull request Aug 28, 2022
pre-commit started failing with:

```
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment

more info:

virtualenv python version did not match created version:
- actual version: 3.10.6.final.0
- expected version: 3.10.4.final.0
```

Quick fix while #696 gets on track.

Sadly I had to rollback #752 due to PyCQA/isort#1945.
@yajo yajo mentioned this pull request Oct 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #696 (c08455f) into master (dae3198) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   96.58%   96.65%   +0.06%     
==========================================
  Files          41       41              
  Lines        3019     3018       -1     
==========================================
+ Hits         2916     2917       +1     
+ Misses        103      101       -2     
Flag Coverage Δ
unittests 96.65% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/cli.py 97.59% <ø> (+1.07%) ⬆️
copier/main.py 94.41% <ø> (ø)
copier/subproject.py 97.56% <ø> (ø)
copier/template.py 96.26% <ø> (ø)
copier/types.py 85.41% <ø> (ø)
copier/user_data.py 94.52% <ø> (ø)
copier/vcs.py 97.67% <ø> (ø)
devtasks.py 0.00% <ø> (ø)
tests/test_migrations.py 100.00% <ø> (ø)
copier/__main__.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yajo
Copy link
Member Author

yajo commented Nov 8, 2022

Cool! This is now working! To try it out:

nix shell github:copier-org/copier/precommix

That will load copier installed with nix in your shell. Now go play with it.

Pending: docs, fix CI (all should break right now), provide more arches.

@yajo yajo changed the title Precommix Nix flake Jan 17, 2023
@yajo yajo marked this pull request as ready for review January 18, 2023 08:42
@yajo yajo enabled auto-merge (squash) January 18, 2023 09:34
@yajo yajo merged commit 67cc4ff into master Jan 18, 2023
@yajo yajo deleted the precommix branch January 18, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide nix flake
6 participants