Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(isort): install with poetry #759

Merged
merged 1 commit into from Aug 28, 2022
Merged

build(isort): install with poetry #759

merged 1 commit into from Aug 28, 2022

Conversation

yajo
Copy link
Member

@yajo yajo commented Aug 28, 2022

pre-commit started failing with:

[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment

more info:

virtualenv python version did not match created version:
- actual version: 3.10.6.final.0
- expected version: 3.10.4.final.0

Quick fix while #696 gets on track.

Sadly I had to rollback #752 due to PyCQA/isort#1945.

@yajo yajo added bug dependencies Pull requests that update a dependency file labels Aug 28, 2022
@yajo yajo self-assigned this Aug 28, 2022
@yajo yajo added this to the Next milestone Aug 28, 2022
@yajo yajo enabled auto-merge August 28, 2022 08:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #759 (29bc69a) into master (29bc69a) will not change coverage.
The diff coverage is n/a.

❗ Current head 29bc69a differs from pull request most recent head 346ddac. Consider uploading reports for the commit 346ddac to get more accurate results

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          41       41           
  Lines        2930     2930           
=======================================
  Hits         2831     2831           
  Misses         99       99           
Flag Coverage Δ
unittests 96.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sisp
Copy link
Member

sisp commented Aug 28, 2022

Yes, it's a an annoying situation with bad practices spreading in the Python ecosystem partly due to bad Poetry defaults. You found my issue over at the isort repo. 👍 I hope it gets resolved soon, but project activity has gone down there quite a bit. 😕

pre-commit started failing with:

```
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment

more info:

virtualenv python version did not match created version:
- actual version: 3.10.6.final.0
- expected version: 3.10.4.final.0
```

Quick fix while #696 gets on track.

Sadly I had to rollback #752 due to PyCQA/isort#1945.
@yajo
Copy link
Member Author

yajo commented Aug 28, 2022

I see. Maybe the issue should be opened in poetry itself.

@sisp
Copy link
Member

sisp commented Aug 28, 2022

I haven't tried it, but would only capping isort to Python <4.0 work instead of capping the Python version for the entire Copier project?

@yajo yajo disabled auto-merge August 28, 2022 08:27
@yajo yajo enabled auto-merge (rebase) August 28, 2022 08:30
@yajo
Copy link
Member Author

yajo commented Aug 28, 2022

I just tried it and it doesn't work. Actually I discovered that #752 was buggy anyways due to questionary having the same problem.

@sisp
Copy link
Member

sisp commented Aug 28, 2022

Oh, I hadn't noticed that. Sorry. 🙇

@sisp
Copy link
Member

sisp commented Aug 28, 2022

I've created a PR over at questionary that removes the Python version upper bound: tmbo/questionary#249

@sisp
Copy link
Member

sisp commented Aug 28, 2022

About raising the issue over at the Poetry project: python-poetry/poetry#3757 The Poetry maintainers seem to be resistant on this topic. 😕

@yajo yajo merged commit d5e2257 into master Aug 28, 2022
@yajo yajo deleted the poetry-isort branch August 28, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants