New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(isort): install with poetry #759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 41 41
Lines 2930 2930
=======================================
Hits 2831 2831
Misses 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes, it's a an annoying situation with bad practices spreading in the Python ecosystem partly due to bad Poetry defaults. You found my issue over at the |
pre-commit started failing with: ``` [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment more info: virtualenv python version did not match created version: - actual version: 3.10.6.final.0 - expected version: 3.10.4.final.0 ``` Quick fix while #696 gets on track. Sadly I had to rollback #752 due to PyCQA/isort#1945.
I see. Maybe the issue should be opened in poetry itself. |
I haven't tried it, but would only capping |
I just tried it and it doesn't work. Actually I discovered that #752 was buggy anyways due to questionary having the same problem. |
Oh, I hadn't noticed that. Sorry. 🙇 |
I've created a PR over at |
About raising the issue over at the Poetry project: python-poetry/poetry#3757 The Poetry maintainers seem to be resistant on this topic. 😕 |
pre-commit started failing with:
Quick fix while #696 gets on track.
Sadly I had to rollback #752 due to PyCQA/isort#1945.