Detect the original file newline style and apply it to rendered template #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves my problem with Windows, any way this could be merge? |
|
I think this is bitting several Windows users for some of the Cookiecutter project generators I have: tiangolo/full-stack-fastapi-couchbase#8, tiangolo/full-stack-fastapi-template#13 I guess this is probably bitting many more users of other Cookiecutters. Is there a chance a maintainer can take a look at this PR? Is there any help we can provide? |
|
We are also affected by this. This would solve many problems with generated unix files on windows. |
franciscomoma
force-pushed
the
detect-original-line-endings
branch
from
6c231ee
to
f1fc75f
Compare
added 3 commits
November 4, 2019 17:52
Synck fork with Cookiecutter
michaeljoseph
added
the
needs-review
This was referenced Apr 18, 2020
insspb
added
feature
insspb
added
WIP
|
@franciscomoma Merged to #1407 |
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've seen that this issue was still open, and I decided to fix it detecting the original file ending style and applying it to the rendered new file.
I've also added a .gitattributes file to set CRLF to files that ends with *crlf.txt.