#405 : Failing test showing that line endings are converted to CRLF #406
Conversation
|
and this fails alright as it should |
|
@audreyr do not apply this for now. It needs to be refined first. |
|
🔔 What's the status on this PR? |
|
@pydanny no idea :) let me rebase this first! |
|
This is rebased and should pass the tests.... Yet the issue is still there: CRLF should not be translated to LF. That said, I have lost a lot (or most) of my patience for these kind of Windows minutiae. |
Current coverage is 99.66%
@@ master #406 diff @@
========================================
Files 13 13
Lines 583 583
Methods 0 0
Messages 0 0
Branches 0 0
========================================
- Hits 583 581 -2
- Misses 0 2 +2
Partials 0 0
|
|
This is driving me nuts as well. I've converted all files in the cookiecutter template to LF, created a .gitattributes file forcing line endings to LF (both in the template repo and in the project repo), and still the project keeps getting created with CRLF line endings! Any bright ideas? |
|
@pombredanne There are some conflicts that need to be fixed for that if is to be merged 👍 |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
@theodesp I rebased... but the vcs test patterns have evolved quite bit since last year so it may not pass... feel free to update as needed to make this mergeable. NOTE: I did not check if the patch is still working either. Busy on other stuffs atm. I just rebased |
|
@theodesp tests are failing ... make it pass if you want this in! It is not like I thoroughly enjoy keeping patches alive for 2.5 years ..... ;) so it is yours now or anyone else ;) |
|
@theodesp basically the code context has changed too much... This would need to be redone from the start |
| utils.rmtree('cookiecutter-pypackage') | ||
|
|
||
|
|
||
| def test_hg_clone_does_not_change_line_endings_on_win(): |
There was a problem hiding this comment.
This is critical and unacceptable. External executable should not be used in tests (hg in this case)
|
|
||
|
|
||
| def test_git_clone_does_not_change_line_endings_on_win(): | ||
| repo_dir = vcs.clone( |
There was a problem hiding this comment.
This is critical and unacceptable. External executable should not be used in tests (git in this case)
There was a problem hiding this comment.
@insspb you are correct ... and way back then, I might have been lazy to use mocks ;)
Thank you for picking up the ball and I am glad this was of some use after all.
|
Restored as #1407 |
This test will fail on Windows for now until #405 is fixed