Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an updated CI image with OCI-capable registry #1679

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jun 16, 2022

… from #1676 containers/automation_images#137 .

The registry usage updates come from #1676 .

@mtrmac mtrmac force-pushed the test-registry-2.8.1-from-image branch from f902531 to c5402bf Compare June 16, 2022 16:29
@mtrmac mtrmac changed the title DO NOT MERGE: Test updated CI image Use an updated CI image with OCI-capable registry Jun 16, 2022
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 16, 2022

The updated CI image is now merged, this is ready for review.

@mtrmac mtrmac marked this pull request as ready for review June 16, 2022 16:31
... from containers/automation_images#137 .

This updates the docker/distribution registry to 2.8.1, allowing it
to accept OCI images.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We expect schema1 images to work.  Also, docker/distribution
doesn't provide useful errors for rejected schema1 images
( distribution/distribution#2925 ),
which makes it impractical for Skopeo to automatically convert
schema1 to schema2.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@vrothberg
Copy link
Member

/lgtm

@rhatdan rhatdan merged commit 1465088 into containers:main Jun 17, 2022
@mtrmac mtrmac deleted the test-registry-2.8.1-from-image branch June 17, 2022 18:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants