Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the registry used for Skopeo CI to 2.8.1 #137

Merged
merged 1 commit into from Jun 16, 2022

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Jun 13, 2022

... primarily so that it accepts OCI-formatted images.

Proof of concept, as well as other updates necessary to work with that registry version, are in containers/image#1574 .

See containers/skopeo#1673 for more context.

@mtrmac
Copy link
Contributor Author

mtrmac commented Jun 13, 2022

@lsm5 do you happen to know what the 404 on https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/testing/xUbuntu_21.10 is about? Perhaps #134 needs to happen first?

@lsm5
Copy link
Member

lsm5 commented Jun 14, 2022

I have re-enabled 21.10 on that repo. We should switch to ubuntu 22.04 soon.

@cevich looks like we didn't take this one into account for the switch to 22.04

@lsm5
Copy link
Member

lsm5 commented Jun 14, 2022

ah, guess the ubuntu repo update will be handled once #134 merges

@lsm5
Copy link
Member

lsm5 commented Jun 14, 2022

@mtrmac the libseccomp.sudo target no longer exists and should be removed as well. I already have a change for that in https://github.com/containers/automation_images/pull/134/files#diff-d75a5ea81fbeeca6f8dc437d1a8dcc6186a4ea8325dd7b1a34fb81c12411adbfL20

mtrmac added a commit to mtrmac/automation_images that referenced this pull request Jun 14, 2022
A part of containers#134 ,
recommended in containers#137 (comment) .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@cevich
Copy link
Member

cevich commented Jun 14, 2022

I think maybe we can just merge #134 and #136. It's seeming like only podman CI is held up on the new images, and maybe the image content can just be updated in a new PR (here) if needed. No reason to hold up the train.

@cevich
Copy link
Member

cevich commented Jun 14, 2022

okay, @mtrmac those two are merged. You'll want to rebase this on main and run it again. But wait for it to finish (pass or fail) or it will orphan VMs.

@mtrmac
Copy link
Contributor Author

mtrmac commented Jun 14, 2022

@cevich

But wait for it to finish (pass or fail) or it will orphan VMs.

By “it”, do you mean the current test of this PR, or something else?

@cevich
Copy link
Member

cevich commented Jun 14, 2022

Yes, sorry for being vague. It's good to go now.

... primarily so that it accepts OCI-formatted images.

Proof of concept, as well as other updates necessary
to work with that registry version, are in
containers/image#1574 .

See containers/skopeo#1673
for more context.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@cevich
Copy link
Member

cevich commented Jun 14, 2022

Changes LGTM. Assuming the build is successful, the github bot will post a comment containing the new Image ID you can stick into skopeo's .cirrus.yml.

@github-actions
Copy link

Cirrus CI build successful. Image ID c6340043416535040 ready for use.

@cevich
Copy link
Member

cevich commented Jun 14, 2022

@mtrmac feel free to merge this if downstream testing in skopeo is happy now with c6340043416535040.

mtrmac added a commit to mtrmac/skopeo that referenced this pull request Jun 16, 2022
... from containers/automation_images#137 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Contributor Author

mtrmac commented Jun 16, 2022

Testing containers/skopeo#1679 (needs to pass) and containers/skopeo#1679 containers/skopeo#1680 (why we need the new registry, but the code might be broken for other reasons).

@mtrmac
Copy link
Contributor Author

mtrmac commented Jun 16, 2022

Both passing, merging. @cevich thanks for all the help!

@mtrmac mtrmac merged commit 00de9f4 into containers:main Jun 16, 2022
@mtrmac mtrmac deleted the skopeo-registry-2.8.1 branch June 16, 2022 16:27
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Jun 16, 2022
... from containers/automation_images#137 .

This updates the docker/distributino registry to 2.8.1, allowing it
to accept OCI images.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/image that referenced this pull request Jun 16, 2022
... from containers/automation_images#137 .

This updates the docker/distribution registry to 2.8.1, allowing it
to accept OCI images.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Jun 16, 2022
... from containers/automation_images#137 .

This updates the docker/distribution registry to 2.8.1, allowing it
to accept OCI images.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/image that referenced this pull request Jun 17, 2022
... from containers/automation_images#137 .

This updates the docker/distribution registry to 2.8.1, allowing it
to accept OCI images.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants