Add OCI artifact support, test syncing Cosign signatures again #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
from
2ea01cf
to
428b19b
Compare
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
2 times, most recently
from
fce9cad
to
dcbd96d
Compare
|
This now vendors c/image from the main branch again. From a Skopeo point of view it could be merged, but we need containers/image#1581 first so that the c/image CI doesn’t break. |
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
from
dcbd96d
to
d021055
Compare
mtrmac
changed the title
|
Now mergeable. Note that it still vendors an unreleased c/image. |
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
2 times, most recently
from
cb3b949
to
9a2c49d
Compare
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
from
9a2c49d
to
e8da053
Compare
|
@vrothberg PTAL |
|
/lgtm |
|
Ah, no bot here. @mtrmac, could you rebase before we force merge? |
including containers/image#1574 . > go get github.com/containers/image/v5@main > make vendor Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This reverts commit bbdabeb. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
test-registry-2.8.1-with-cosign-signatures
branch
from
e8da053
to
61593fc
Compare
|
Rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1679 + containers/image#1574 + #1673 .