Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 #12256

Merged
merged 14 commits into from Apr 17, 2023
Merged

Python 3.11 #12256

merged 14 commits into from Apr 17, 2023

Conversation

johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Jan 19, 2023 •
edited by kenodegard

Python 3.11 build
Pillow >=9.3.0

Xref #11170

Depends on #12580

@johnnynunez johnnynunez requested a review from a team as a code owner January 19, 2023 16:54
@dholth
Copy link
Contributor

dholth commented Jan 19, 2023

We must use Pillow in the docs

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @johnnynunez.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Jan 19, 2023 •
edited

We must use Pillow in the docs

Pillow 9.3.0 supports python 3.11 python-pillow/Pillow#6575
https://github.com/conda/conda/blob/1c2264ecf9bba41db640f51c655c899313a8fb43/docs/requirements.txt

@jezdez
Copy link
Member

jezdez commented Jan 20, 2023

FWIW there is a good chance that not all dependencies are already built for Python 3.11 on Anaconda's default channel, this is expected. Thanks for starting the work though!

@jezdez jezdez mentioned this pull request Jan 20, 2023
Closed
3 tasks
@jezdez jezdez mentioned this pull request Jan 30, 2023
Closed
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 30, 2023
@travishathaway travishathaway added the source::community catch-all for issues filed by community members label Feb 16, 2023
@johnnynunez johnnynunez reopened this Feb 27, 2023
@johnnynunez johnnynunez reopened this Mar 16, 2023
@johnnynunez
Copy link
Contributor Author

This conda image not exists :( ghcr.io/conda/conda-ci:main-linux-python3.11

@jezdez
Copy link
Member

jezdez commented Mar 31, 2023

This conda image not exists :( ghcr.io/conda/conda-ci:main-linux-python3.11

We need to split this into two PRs, one that modifies the images workflow to generate the 3.11 compatible image, and then one that has the other changes.

@kenodegard kenodegard mentioned this pull request Apr 10, 2023
Merged
3 tasks
kenodegard
kenodegard previously approved these changes Apr 17, 2023
View reviewed changes
@kenodegard kenodegard mentioned this pull request Apr 17, 2023
Closed
beeankha
beeankha reviewed Apr 17, 2023
View reviewed changes
docs/source/user-guide/tasks/use-conda-with-travis-ci.rst
@@ -26,7 +26,7 @@ The .travis.yml file

The following code sample shows how to modify the ``.travis.yml``
file to use `Miniconda <https://conda.io/miniconda.html>`_ for a
project that supports Python 3.7, 3.8, 3.9 and 3.10:
project that supports Python 3.7, 3.8, 3.9, 3.10, and 3.11:
Copy link
Contributor

@beeankha beeankha Apr 17, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we wanna remove 3.7 from this list, or do we indeed include 3.7 with Travis CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should just remove this page instead since we no longer use Travis CI: #12602

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout @beeankha! We should just remove the file, as we don't support Travis CI anymore and shouldn't advertise it either. This can happen in the other PR though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way let's resolve this particular concern in #12602

@kenodegard kenodegard merged commit 7ec97d6 into conda:main Apr 17, 2023
91 checks passed
This was referenced Apr 18, 2023
Closed
Open
Closed
Open
@kenodegard kenodegard mentioned this pull request Apr 28, 2023
Closed
@sven6002 sven6002 mentioned this pull request May 22, 2023
Closed
6 tasks
travishathaway added a commit that referenced this pull request Jun 6, 2023
@johnnynunez @travishathaway @kenodegard
Add Python 3.11 support (#12256)
3271386 
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kenodegard kenodegard kenodegard approved these changes

@beeankha beeankha beeankha left review comments

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::community catch-all for issues filed by community members
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@johnnynunez @dholth @conda-bot @jezdez @kenodegard @beeankha @travishathaway