Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #11170

Closed
2 tasks done
Tracked by #4370
kenodegard opened this issue Jan 27, 2022 · 19 comments
Closed
2 tasks done
Tracked by #4370

Python 3.11 support #11170

kenodegard opened this issue Jan 27, 2022 · 19 comments
Assignees
Labels
duplicate::primary if an issue/PR has duplicates, this is the consolidated, primary issue/PR ¡important! used to indicate particularly notable information in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Milestone

Comments

@kenodegard
Copy link
Contributor

kenodegard commented Jan 27, 2022

Description

We need to investigate the changes necessary to support Python 3.11. Because this release cycle happens every year. It would also make sense for us to have a policy in place guiding the work that we need to regularly complete for this.

Good to know

There is currently a rough draft of this document that could be used as a starting point for the work:
conda/ceps#24

Tasks

  1. cla-signed locked source::community
  2. cla-signed locked
    kenodegard
@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package ¡important! used to indicate particularly notable information labels Jan 27, 2022
@jezdez jezdez added this to the Release TBD milestone Feb 8, 2022
@kenodegard kenodegard added sync::anaconda sync internally with Anaconda, Inc. ticket tracker backlog issue has been triaged but has not been earmarked for any upcoming release labels Feb 10, 2022
@EwoutH
Copy link

EwoutH commented May 17, 2022

Python 3.11 is now in beta, which means no new features will be added.

@travishathaway
Copy link
Contributor

In response to this issue, I have created the following draft CEP (Conda Enhancement Proposal):

conda/ceps#24

After finishing and adopting this CEP, conda will have an official policy surrounding new (C)Python version adoption.

@awwad awwad changed the title Python 3.11 support CEP Drafting for Python 3.11 support Jul 20, 2022
@travishathaway travishathaway self-assigned this Sep 21, 2022
@kenodegard kenodegard changed the title CEP Drafting for Python 3.11 support Python 3.11 support Sep 29, 2022
@EwoutH
Copy link

EwoutH commented Oct 10, 2022

Any update on this effort? Python 3.11 is now in the release candidate phase and will be released in two weeks. Many projects already support Python 3.11 and have wheels available, including NumPy, Pandas, SciPy, Matplotlib and Seaborn.

@travishathaway
Copy link
Contributor

@EwoutH, thanks for checking in. This issue is high on our priority list, and we hope to begin working on it in an upcoming sprint. I can not say for certain when this will be completed though.

@EwoutH
Copy link

EwoutH commented Oct 18, 2022

Thanks for getting back! Great to hear the team is working on this, keep us in the loop :)

@johnnynunez
Copy link
Contributor

Yeah! Python 3.11 support please. It should be the default.
Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite. See Faster CPython for details.
https://docs.python.org/3.11/whatsnew/3.11.html
https://www.phoronix.com/news/Python-3.11-Released

@soumendrak
Copy link

Python 3.11.0 support please 🙏🏼

@johnnynunez
Copy link
Contributor

@EwoutH
Copy link

EwoutH commented Oct 27, 2022

Hi @travishathaway! Do you have anything to share as of this moment?

@kingmo888
Copy link

Anxious expectation python 3.11.0

@EwoutH
Copy link

EwoutH commented Dec 15, 2022

We're now over 4 months over rc1 and almost two months after stable release. It's blocking many major projects. Could we get an update on 3.11 support?

pcmoritz pushed a commit to ray-project/ray that referenced this issue Jan 7, 2023
Preliminary PR for adding Python 3.11 support, mapping out various dependencies, fixing issues.

### Main changes

- Upgrade cython to 0.29.32
- Add CI/CD steps for 3.11 wheel
- Change cython code to not use `recursion_depth`
- Update cloudpickle to latest
- Use newer manylinux2014 which has python3.11
- Condition certain python packages in requirements.txt on <3.11 that don't yet have a 3.11 version

### Checklist:

- cython
  - [x] remove deprecated `recursion_depth`
  - [x] exc_type cython/cython#4500
- [ ] package dependencies https://pyreadiness.org/3.11/
  - [ ] llvmlite numba/llvmlite#869
  - [ ] numba numba/numba#8304
  - [ ] pyarrow
  - [ ] scikit-learn
  - [ ] pydantic
  - [x] cloudpickle
  - [x] upgrade cython to 0.29.32
  - [ ] tensorflow tensorflow/tensorflow#58032
  - [ ] torch pytorch/pytorch#86566
  - [ ] miniconda conda/conda#11170
    - [ ] `docker/base-deps/Dockerfile`
- [x] claim to support 3.11 in setup.py
- [ ] cicd
  - [ ] .buildkite/
    - [ ] .buildkite/pipeline.build.yml
  - [ ] ci/
    - [ ] ci/build/test-wheels.sh
    - [ ] ci/build/build-docker-images.py
  - [ ] release tests
  - [ ] docker/retag-lambda/python_versions.txt
  - [ ] download_wheels.sh
  - [ ] wheels
    - [ ] `python/build-wheel-macos.sh`
    - [ ] `python/build-wheel-windows.sh`
- [ ] Tests
  - [ ] pytest ray/serve/tests
  - [ ] python python/ray/serve/examples/echo_full.py
  - [ ] bazel test //:core_worker_test
  - [ ] bazel test --build_tests_only //:all
  - [ ] //python/ray/tests:test_pydantic_serialization tiangolo/fastapi#5048
  - [ ] //python/ray/train:test_torch_utils
- [ ] Documentation
  - [x] installation.rst

Current status: 
Linux and mac wheels build in CICD. Docker images will come in a separate PR.
AmeerHajAli pushed a commit to ray-project/ray that referenced this issue Jan 12, 2023
Preliminary PR for adding Python 3.11 support, mapping out various dependencies, fixing issues.

### Main changes

- Upgrade cython to 0.29.32
- Add CI/CD steps for 3.11 wheel
- Change cython code to not use `recursion_depth`
- Update cloudpickle to latest
- Use newer manylinux2014 which has python3.11
- Condition certain python packages in requirements.txt on <3.11 that don't yet have a 3.11 version

### Checklist:

- cython
  - [x] remove deprecated `recursion_depth`
  - [x] exc_type cython/cython#4500
- [ ] package dependencies https://pyreadiness.org/3.11/
  - [ ] llvmlite numba/llvmlite#869
  - [ ] numba numba/numba#8304
  - [ ] pyarrow
  - [ ] scikit-learn
  - [ ] pydantic
  - [x] cloudpickle
  - [x] upgrade cython to 0.29.32
  - [ ] tensorflow tensorflow/tensorflow#58032
  - [ ] torch pytorch/pytorch#86566
  - [ ] miniconda conda/conda#11170
    - [ ] `docker/base-deps/Dockerfile`
- [x] claim to support 3.11 in setup.py
- [ ] cicd
  - [ ] .buildkite/
    - [ ] .buildkite/pipeline.build.yml
  - [ ] ci/
    - [ ] ci/build/test-wheels.sh
    - [ ] ci/build/build-docker-images.py
  - [ ] release tests
  - [ ] docker/retag-lambda/python_versions.txt
  - [ ] download_wheels.sh
  - [ ] wheels
    - [ ] `python/build-wheel-macos.sh`
    - [ ] `python/build-wheel-windows.sh`
- [ ] Tests
  - [ ] pytest ray/serve/tests
  - [ ] python python/ray/serve/examples/echo_full.py
  - [ ] bazel test //:core_worker_test
  - [ ] bazel test --build_tests_only //:all
  - [ ] //python/ray/tests:test_pydantic_serialization tiangolo/fastapi#5048
  - [ ] //python/ray/train:test_torch_utils
- [ ] Documentation
  - [x] installation.rst

Current status: 
Linux and mac wheels build in CICD. Docker images will come in a separate PR.
@kenodegard kenodegard added the duplicate::primary if an issue/PR has duplicates, this is the consolidated, primary issue/PR label Mar 6, 2023
@RNarayan73
Copy link

Due to be released on March 14, fingers crossed!
https://www.anaconda.com/blog/upcoming-releases-anaconda-distribution-2023-03-and-beyond#:~:text=Python%203.11%20support%20will%20be,of%20Anaconda's%20biggest%20releases%20yet!

@kenodegard kenodegard modified the milestones: 23.3.0, 23.5.0 Mar 14, 2023
@rickyyx
Copy link

rickyyx commented Mar 16, 2023

Didn't see relevant info of 3.11 in the release note: https://github.com/conda/conda/releases/tag/23.3.0

But are we having 3.11 support officially?

@johnnynunez
Copy link
Contributor

Didn't see relevant info of 3.11 in the release note: https://github.com/conda/conda/releases/tag/23.3.0

But are we having 3.11 support officially?

there are binaries for python 3.11 but not all

scv119 added a commit to ray-project/ray that referenced this issue Mar 17, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this issue Mar 21, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
cadedaniel pushed a commit to cadedaniel/ray that referenced this issue Mar 22, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
@kenodegard kenodegard added in-progress issue is actively being worked on and removed backlog issue has been triaged but has not been earmarked for any upcoming release labels Mar 22, 2023
@johnnynunez
Copy link
Contributor

johnnynunez commented Mar 22, 2023

When will the python3.11 image be available for testing? ghcr.io/conda/conda-ci:main-linux-python3.11

edoakes pushed a commit to edoakes/ray that referenced this issue Mar 22, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
scottsun94 pushed a commit to scottsun94/ray that referenced this issue Mar 28, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this issue Mar 28, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
chaowanggg pushed a commit to chaowanggg/ray-dev that referenced this issue Apr 4, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
Signed-off-by: chaowang <chaowang@anyscale.com>
@kenodegard
Copy link
Contributor Author

Python 3.11 support added via #12256, this will be included in the May release of conda 23.5.0

@EwoutH
Copy link

EwoutH commented Apr 18, 2023

Awesome, great to hear!

Maybe this process can now be documented, while it's still fresh in everyones memory, so that it doesn't take so long for future Python releases.

elliottower pushed a commit to elliottower/ray that referenced this issue Apr 22, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this issue May 4, 2023
This PR adds 3.11 in the allowed runtime env conda version which was made available during the recent conda 2.23.0 release. conda/conda#11170 (comment)

It also fixes a a wheel rename for mac osx wheels from "*_intel.whl" to "*x86_64.whl" in recent builds.

A previous intel wheel build for mac:https://buildkite.com/ray-project/oss-ci-build-branch/builds/1268#0184a81c-6dd7-4cd2-8534-b6f763b8ce24
A more recent x86_64 name wheel build: https://buildkite.com/ray-project/oss-ci-build-branch/builds/2599#0186badf-4b95-44fd-b57d-6e42d5462c1d

Signed-off-by: rickyyx <rickyx@anyscale.com>
Co-authored-by: scv119 <scv119@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
carlthome added a commit to carlthome/mir_eval that referenced this issue Jun 15, 2023
Since miniconda hasn't released Python 3.11 support yet as per conda/conda#11170 (comment)
craffel pushed a commit to craffel/mir_eval that referenced this issue Jun 22, 2023
* Add initial test workflow

* Add decorator as test dependency

* Move test dependencies into extras_require

* Add environment.yml with packages taken from .travis.yml

* Limit concurrency

* Only trigger on PRs to default branch

* Only upgrade packages if needed

* Use conda-incubator/setup-miniconda instead of actions/setup-python

* Remove atlas

* Rename test.yaml to test.yml

* `python -m pip`

* Use login shell so conda environment gets activated

* Remove dependencies

* Remove upper bound on matplotlib

* Expand build matrix

1. Use both flexible and strict channel priority for conda environment.
2. Include macOS and Windows for latest Python version.

* Set use-only-tar-bz2 for caching

As per https://github.com/conda-incubator/setup-miniconda/tree/v2/#caching-packages

* Remove redundant dependency mention

SciPy is already part of install_requires so not necessary to have it
in extras_require as well.

* mpl_ic.image_comparison -> pytest.mark.mpl_image_compare

* Use Python 3.10 as the latest version

Since miniconda hasn't released Python 3.11 support yet as per conda/conda#11170 (comment)

* Install pytest with conda

* Log package and dependency information
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate::primary if an issue/PR has duplicates, this is the consolidated, primary issue/PR ¡important! used to indicate particularly notable information in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

No branches or pull requests

9 participants