Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamo 3.11] enable other torch 3.11 dynamo-related tests #99180

Closed
wants to merge 27 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Apr 14, 2023

Stack from ghstack (oldest at bottom):

Notes:

  • No segfaults observed in any CI tests: dynamo unittests, inductor unittests, dynamo-wrapped pytorch tests. So we remove the warning that using dynamo 3.11 may result in segfaults.
  • Fixed a weakreflist copying bug that caused a few dynamo-wrapped tests to hang.

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99180

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e2b9bc5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

williamwen42 added a commit that referenced this pull request Apr 14, 2023
ghstack-source-id: 925b931ea2d02ff4e32f4f52b9eade2531ed8270
Pull Request resolved: #99180
@williamwen42 williamwen42 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor topic: not user facing topic category labels Apr 14, 2023
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 17, 2023
ghstack-source-id: 9c4658ef615ee6139696ae23a950ebe30b3c3990
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 17, 2023
ghstack-source-id: 3f7b93b51601e8dd79252da49c13bfd58beef7be
Pull Request resolved: #99180
@johnnynunez
Copy link

Python 3.11 support added via conda/conda#12256, this will be included in the May release of conda 23.5.0

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 24, 2023
ghstack-source-id: 8f7504133fe46762e070fd6c50f60ce0f2dc5a10
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 24, 2023
ghstack-source-id: 44f82841e9478de8bb38e54e38bed1ae57684533
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 25, 2023
ghstack-source-id: 8a97505ff1e0279a671acc06337786b693d9034f
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 25, 2023
ghstack-source-id: fdb2dd4eac5a3d2bd4a90a16e29d2dbf9328a9fa
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 25, 2023
ghstack-source-id: cae57df791baff56933fcf810e24a80679ca3b58
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Apr 25, 2023
ghstack-source-id: 060baddd2c5bc4056cb6f45d003dd6b08de6ddd4
Pull Request resolved: #99180
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Notes:
- No segfaults observed in any CI tests: dynamo unittests, inductor unittests, dynamo-wrapped pytorch tests. So we remove the warning that using dynamo 3.11 may result in segfaults.
- Some dynamo-wrapped pytorch tests hang. They will be skipped in the dynamo-wrapped test suite and will be addressed in a future PR

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request May 11, 2023
ghstack-source-id: d49746ef41372fb2468f9a72d4d88e117443cb06
Pull Request resolved: #99180
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented May 12, 2023

@pytorchbot revert -m 'Sorry for reverting this, but linux-bionic-py3.11-clang9 test starts to timeout after this taking more than 3h30m. This is probably a landrace' -c landrace

The timeout test is test_spectral_ops.py

@huydhn huydhn reopened this May 12, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@williamwen42 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request May 12, 2023
…99180)"

This reverts commit aa8dcab.

Reverted #99180 on behalf of https://github.com/huydhn due to Sorry for reverting this, but linux-bionic-py3.11-clang9 test starts to timeout after this taking more than 3h30m. This is probably a landrace ([comment](#99180 (comment)))
Notes:
- No segfaults observed in any CI tests: dynamo unittests, inductor unittests, dynamo-wrapped pytorch tests. So we remove the warning that using dynamo 3.11 may result in segfaults.
- Some dynamo-wrapped pytorch tests hang. They will be skipped in the dynamo-wrapped test suite and will be addressed in a future PR

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request May 12, 2023
ghstack-source-id: 1a498b15d5cb5c2139f987b1fdb673a3c9753990
Pull Request resolved: #99180
Notes:
- No segfaults observed in any CI tests: dynamo unittests, inductor unittests, dynamo-wrapped pytorch tests. So we remove the warning that using dynamo 3.11 may result in segfaults.
- Some dynamo-wrapped pytorch tests hang. They will be skipped in the dynamo-wrapped test suite and will be addressed in a future PR

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request May 15, 2023
ghstack-source-id: 2c0d904a5d16b7bbb3f0cdd32f63b2c39e9d05f9
Pull Request resolved: #99180
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jcaip pushed a commit that referenced this pull request May 23, 2023
Notes:
- No segfaults observed in any CI tests: dynamo unittests, inductor unittests, dynamo-wrapped pytorch tests. So we remove the warning that using dynamo 3.11 may result in segfaults.
- Fixed a weakreflist copying bug that caused a few dynamo-wrapped tests to hang.

Pull Request resolved: #99180
Approved by: https://github.com/malfet, https://github.com/TamirFriedman-RecoLabs
@facebook-github-bot facebook-github-bot deleted the gh/williamwen42/51/head branch June 8, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants