Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop and add rubocop-rspec #15

Merged
merged 7 commits into from Jul 22, 2021
Merged

Update rubocop and add rubocop-rspec #15

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b68591b
Update Rubocop to latest version
flats Jul 20, 2021
66618da
Replace rspec-focused w/ more general library
flats Jul 20, 2021
f8b125f
Bump version
flats Jul 20, 2021
31d1a17
Disable not very useful rule
flats Jul 21, 2021
8258ecc
Disable cop that conflicts w/ Prettier
flats Jul 21, 2021
9aead1c
Disable cop that we do not need
flats Jul 21, 2021
49a74da
Replace custom cop w/ built-in one
flats Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cw-style.gemspec
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "rubocop", "~> 0.89.1"
spec.add_dependency "rubocop-rspec-focused", "= 0.0.3"
spec.add_dependency "rubocop", "~> 1.18.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might be able to replace https://github.com/charitywater/cw-style/blob/master/lib/unless_with_multiple_conditions.rb with rubocop/rubocop#5388 now.

From skimming https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Did that and also ignored a couple more cops that seemed pretty ignorable to me.

spec.add_dependency "rubocop-thread_safety"
spec.add_dependency "rubocop-rails"
spec.add_development_dependency "bundler", "~> 2.2.4"
Expand Down