Update rubocop and add rubocop-rspec #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#177398947]
flats
force-pushed
the
update-rubocop-177398947
branch
from
b4d7ef6
to
ebb1a07
Compare
That covers all things Rspec, including lingering `focus`es. [#177398947]
[#177398947]
flats
force-pushed
the
update-rubocop-177398947
branch
from
ebb1a07
to
f8b125f
Compare
jasdeepgosal
approved these changes
Jul 20, 2021
| spec.add_dependency "rubocop-rspec-focused", "= 0.0.3" | ||
| spec.add_dependency "rubocop", "~> 1.18.3" |
There was a problem hiding this comment.
I think we might be able to replace https://github.com/charitywater/cw-style/blob/master/lib/unless_with_multiple_conditions.rb with rubocop/rubocop#5388 now.
From skimming https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md
There was a problem hiding this comment.
Good catch, thanks! Did that and also ignored a couple more cops that seemed pretty ignorable to me.
We _mostly_ use snakecase for variables with numbers, but not always, and I don't think it's worth the effort to standardize that. [#177398947]
Prettier undoes what autocorrecting this cop does. [#177398947]
We are purposeful about our use of symbols with and without quoted strings and I don't think we need this. [#177398947]
flats
force-pushed
the
update-rubocop-177398947
branch
from
4f30c84
to
58a088b
Compare
Per PR feedback. [#177398947]
flats
force-pushed
the
update-rubocop-177398947
branch
from
58a088b
to
49a74da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.