Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop and add rubocop-rspec #15

Merged
merged 7 commits into from Jul 22, 2021
Merged

Update rubocop and add rubocop-rspec #15

merged 7 commits into from Jul 22, 2021

Commits on Jul 20, 2021

  1. Update Rubocop to latest version 

    [#177398947]
    @flats
    flats committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b68591b View commit details
    Browse the repository at this point in the history

  2. Replace rspec-focused w/ more general library 

    That covers all things Rspec, including lingering `focus`es.

[#177398947]
    @flats
    flats committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    66618da View commit details
    Browse the repository at this point in the history

  3. Bump version 

    [#177398947]
    @flats
    flats committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f8b125f View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Disable not very useful rule 

    We _mostly_ use snakecase for variables with numbers, but not always, and I don't think it's worth the effort to standardize that.

[#177398947]
    @flats
    flats committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    31d1a17 View commit details
    Browse the repository at this point in the history

  2. Disable cop that conflicts w/ Prettier 

    Prettier undoes what autocorrecting this cop does.

[#177398947]
    @flats
    flats committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8258ecc View commit details
    Browse the repository at this point in the history

  3. Disable cop that we do not need 

    We are purposeful about our use of symbols with and without quoted strings and I don't think we need this.

[#177398947]
    @flats
    flats committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    9aead1c View commit details
    Browse the repository at this point in the history

  4. Replace custom cop w/ built-in one 

    Per PR feedback.

[#177398947]
    @flats
    flats committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    49a74da View commit details
    Browse the repository at this point in the history