prettier old version

[dhrubabasu]

Affected Packages

apply-release-plan

Problem

It's relying on an old version of prettier: https://github.com/atlassian/changesets/blob/main/packages/apply-release-plan/package.json#L20

Proposed solution

Is it necessary to ship prettier as a dependency of this package? Could it be moved to devDependencies? If not, upgrade prettier to v2.

[Andarist]

@mitchellhamilton we could probably use an optional peer dependency here, wdyt? that way we could use whatever is installed by the user (conditionally) - the Prettier JS API probably didn't change much for what we need so it should be pretty straightforward to support its both major versions

[emmatown]

Yeah, and maybe until the next major we could try requiring prettier from the project root and use our version if that fails and in a major we'd not use prettier if we can't require it from the project root.

[alexamy]

Hey! Today i'm stuck with these problem too. In yarn workspaces prettier from bin is referencing old version, and its caused by apply-release-plan. Any plans to fix this issue?

Solution: I've added prettier resolution in package.json. Now I have incompatible version warning, but changeset works fine.
package.json:

  "resolutions": {
    "prettier": "2.7.0"
  }

[Andarist]

Hey! Today i'm stuck with these problem too. In yarn workspaces prettier from bin is referencing old version, and its caused by apply-release-plan. Any plans to fix this issue?

I'm not sure I understand this - a demo repository would be helpful. Are you saying that our prettier dependency (transitive one for you) "overrides" your direct dependency and is put within root's~ .bin?

[alexamy]

Yes, you are right. I will try to make a clean repository with this issue.

[alexamy]

In clean repo I can't repeat this. I think it's local error then, so its not changesets related. Thanks!

[Princesseuh]

We're running into an issue on the Astro repo because of the Prettier version being so old. Prettier is trying to run our plugin (prettier-plugin-astro) on the embedded code blocks that use the astro language and since the plugin doesn't work on that version of Prettier (which admittedly, is 3 years old at this point), it just ends up totally nuking the code blocks, here's a diff from a changesets PR:

For now, we'll just disable our plugins inside CHANGELOG.md, but it'd be cool to get this working!

[Andarist]

I've created a PR that, I hope, should fix most of the problems like this: #905