Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Upgrade changesets and remove Prettier version override #3255

Merged
merged 2 commits into from Aug 30, 2022

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Aug 30, 2022

Previously, weirdness would occur on release because of differences in the Prettier formatting for our CHANGELOG files between our auto-formatter and the formatting that Changesets itself tries to do. This was because Changesets had an old version of Prettier, but our repo had a newer version.

We had a workaround for this where we deleted Changesets' version of Prettier, so that ours would be prefered.

Now that changesets/changesets#905 has landed (fixing changesets/changesets#616), Changesets will prefer our version of Prettier. Plus the version they depend on is now up to date. So we can remove the workaround.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: 21db14a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-1.06ms - +0.46ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 110.03ms - 114.35ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-1.05ms - +1.63ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +1% (-0.84ms - +0.10ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.65ms - +1.47ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-2.49ms - +1.39ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1119.56ms - 1136.87ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-4.13ms - +3.07ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -0% - +2% (-1.49ms - +8.05ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-5.14ms - +3.48ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-15.10ms - +8.34ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1140.87ms - 1157.75ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-15.75ms - +7.28ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
110.03ms - 114.35ms-

update

VersionAvg timevs
1119.56ms - 1136.87ms-

update-reflect

VersionAvg timevs
1140.87ms - 1157.75ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
43.20ms - 45.19ms-unsure 🔍
-2% - +4%
-1.05ms - +1.63ms
unsure 🔍
-4% - +4%
-1.65ms - +1.63ms
tip-of-tree
tip-of-tree
43.01ms - 44.80msunsure 🔍
-4% - +2%
-1.63ms - +1.05ms
-unsure 🔍
-4% - +3%
-1.88ms - +1.28ms
previous-release
previous-release
42.90ms - 45.51msunsure 🔍
-4% - +4%
-1.63ms - +1.65ms
unsure 🔍
-3% - +4%
-1.28ms - +1.88ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
112.98ms - 118.60ms-unsure 🔍
-4% - +3%
-4.13ms - +3.07ms
unsure 🔍
-4% - +2%
-4.46ms - +2.69ms
tip-of-tree
tip-of-tree
114.06ms - 118.58msunsure 🔍
-3% - +4%
-3.07ms - +4.13ms
-unsure 🔍
-3% - +2%
-3.51ms - +2.81ms
previous-release
previous-release
114.46ms - 118.88msunsure 🔍
-2% - +4%
-2.69ms - +4.46ms
unsure 🔍
-2% - +3%
-2.81ms - +3.51ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.85ms - 32.83ms-unsure 🔍
-3% - +1%
-1.06ms - +0.46ms
unsure 🔍
-3% - +2%
-0.84ms - +0.79ms
tip-of-tree
tip-of-tree
32.05ms - 33.22msunsure 🔍
-1% - +3%
-0.46ms - +1.06ms
-unsure 🔍
-2% - +4%
-0.60ms - +1.15ms
previous-release
previous-release
31.71ms - 33.02msunsure 🔍
-2% - +3%
-0.79ms - +0.84ms
unsure 🔍
-4% - +2%
-1.15ms - +0.60ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.71ms - 13.12ms-unsure 🔍
-6% - +1%
-0.84ms - +0.10ms
unsure 🔍
-14% - +0%
-2.04ms - +0.12ms
tip-of-tree
tip-of-tree
12.86ms - 13.71msunsure 🔍
-1% - +7%
-0.10ms - +0.84ms
-unsure 🔍
-12% - +4%
-1.73ms - +0.55ms
previous-release
previous-release
12.82ms - 14.93msunsure 🔍
-1% - +16%
-0.12ms - +2.04ms
unsure 🔍
-4% - +13%
-0.55ms - +1.73ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
353.79ms - 360.40ms-unsure 🔍
-0% - +2%
-1.49ms - +8.05ms
unsure 🔍
-2% - +1%
-6.37ms - +4.90ms
tip-of-tree
tip-of-tree
350.38ms - 357.25msunsure 🔍
-2% - +0%
-8.05ms - +1.49ms
-unsure 🔍
-3% - +0%
-9.73ms - +1.69ms
previous-release
previous-release
353.27ms - 362.40msunsure 🔍
-1% - +2%
-4.90ms - +6.37ms
unsure 🔍
-0% - +3%
-1.69ms - +9.73ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
70.97ms - 72.54ms-unsure 🔍
-2% - +2%
-1.65ms - +1.47ms
unsure 🔍
-3% - +0%
-2.37ms - +0.07ms
tip-of-tree
tip-of-tree
70.50ms - 73.20msunsure 🔍
-2% - +2%
-1.47ms - +1.65ms
-unsure 🔍
-4% - +1%
-2.70ms - +0.58ms
previous-release
previous-release
71.97ms - 73.84msunsure 🔍
-0% - +3%
-0.07ms - +2.37ms
unsure 🔍
-1% - +4%
-0.58ms - +2.70ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
156.37ms - 162.19ms-unsure 🔍
-3% - +2%
-5.14ms - +3.48ms
unsure 🔍
-3% - +2%
-4.31ms - +3.73ms
tip-of-tree
tip-of-tree
156.92ms - 163.29msunsure 🔍
-2% - +3%
-3.48ms - +5.14ms
-unsure 🔍
-2% - +3%
-3.68ms - +4.76ms
previous-release
previous-release
156.79ms - 162.34msunsure 🔍
-2% - +3%
-3.73ms - +4.31ms
unsure 🔍
-3% - +2%
-4.76ms - +3.68ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.06ms - 80.79ms-unsure 🔍
-3% - +2%
-2.49ms - +1.39ms
slower ❌
0% - 3%
0.27ms - 2.56ms
tip-of-tree
tip-of-tree
78.73ms - 82.21msunsure 🔍
-2% - +3%
-1.39ms - +2.49ms
-slower ❌
0% - 5%
0.07ms - 3.86ms
previous-release
previous-release
77.76ms - 79.26msfaster ✔
0% - 3%
0.27ms - 2.56ms
faster ✔
0% - 5%
0.07ms - 3.86ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1109.01ms - 1124.15ms-unsure 🔍
-1% - +1%
-15.10ms - +8.34ms
unsure 🔍
-1% - +1%
-11.75ms - +10.11ms
tip-of-tree
tip-of-tree
1111.02ms - 1128.91msunsure 🔍
-1% - +1%
-8.34ms - +15.10ms
-unsure 🔍
-1% - +1%
-9.36ms - +14.49ms
previous-release
previous-release
1109.51ms - 1125.28msunsure 🔍
-1% - +1%
-10.11ms - +11.75ms
unsure 🔍
-1% - +1%
-14.49ms - +9.36ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1154.70ms - 1169.17ms-unsure 🔍
-1% - +1%
-15.75ms - +7.28ms
unsure 🔍
-1% - +1%
-6.93ms - +13.21ms
tip-of-tree
tip-of-tree
1157.21ms - 1175.13msunsure 🔍
-1% - +1%
-7.28ms - +15.75ms
-unsure 🔍
-0% - +2%
-3.99ms - +18.75ms
previous-release
previous-release
1151.78ms - 1165.80msunsure 🔍
-1% - +1%
-13.21ms - +6.93ms
unsure 🔍
-2% - +0%
-18.75ms - +3.99ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of this!

@aomarks aomarks merged commit 0275bd0 into main Aug 30, 2022
@aomarks aomarks deleted the changesets-prettier branch August 30, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants