Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent prettier --check on CHANGELOG #664

Merged
merged 1 commit into from Mar 22, 2022

Conversation

threepointone
Copy link
Contributor

changesets currently relies on on older version of prettier when generating changelogs, which then makes our prettier --check run fail during releases, which breaks our releases (.20. .21, .22). ref: changesets/changesets#616. The fix for now is to simply ignore the changelog when generating the check.

changesets currently relies on on older version of prettier when generating changelogs, which then makes our `prettier --check` run fail during releases, which breaks our releases (.20. .21, .22). ref: changesets/changesets#616. The fix for now is to simply ignore the changelog when generating the check.
@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2022

⚠️ No Changeset found

Latest commit: b5e9447

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2020080199/npm-package-wrangler-664

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/664/npm-package-wrangler-664

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2020080199/npm-package-wrangler-664 dev path/to/script.js

@threepointone threepointone mentioned this pull request Mar 22, 2022
@threepointone threepointone merged commit d504e34 into main Mar 22, 2022
@threepointone threepointone deleted the prevent-prettier-check-on-changelog branch March 22, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant