-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changelog generation #6299
Fix changelog generation #6299
Conversation
|
@ybiquitous @jeddy3 Are we good to go forward? |
d006ab4
to
8daf9ca
Compare
8daf9ca
to
c88f636
Compare
friendly ping @ybiquitous @jeddy3 |
f31fafd
to
982c48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run npm run version
, the extra sections are not inserted. Thank you.
Instead, the - patch
line is inserted. Here is an example of CHANGELOG.md
diff:
@@ -1,5 +1,10 @@
# Changelog
+## 14.12.0
+
+- patch
+- Added: `declaration-block-no-duplicate-properties` autofix ([#6296](https://github.com/stylelint/stylelint/pull/6296)) ([@fpetrakov](https://github.com/fpetrakov)). - minor
+
## 14.11.0
- Added: `ignoreAfterCombinators: []` to `selector-max-universal` ([#6275](https://github.com/stylelint/stylelint/pull/6275)).
Interesting, let me check. It seems I forget to check whether the content exists. @ybiquitous It should be fixed. |
982c48d
to
a1d8e08
Compare
a1d8e08
to
04fa96e
Compare
d81fb8d
to
6617e6e
Compare
6ec05ae
to
aa63f3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍🏼
I locally confirm it works:
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,16 @@
# Changelog
+## 15.0.0
+
+- Removed: `foo` rule. (BREAKING)
+- Changed: `foo` rule. (BREAKING)
+- Deprecated: `foo` rule.
+- Added: `bar` rule.
+- Added: `declaration-block-no-duplicate-properties` autofix ([#6296](https://github.com/stylelint/stylelint/pull/6296)) ([@fpetrakov](https://github.com/fpetrakov)).
+- Added: `foo` rule.
+- Fixed: `bar` rule.
+- Fixed: `foo` rule.
+
## 14.11.0
- Added: `ignoreAfterCombinators: []` to `selector-max-universal` ([#6275](https://github.com/stylelint/stylelint/pull/6275)).
changeset version
@ybiquitous Let's merge? cc @jeddy3 |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
aa63f3a
to
8dfc452
Compare
Let's wait for other reviews. |
I think we can merge now? @ybiquitous |
I'm curious about the other members' thoughts on the patch and the tricky script, so let's wait for feedback a little longer. By the way, I notice changesets/changesets#616 was closed today. Is |
It seems there are only us two invoked in this PR.
Nice catch, |
3b6404f
to
d0a871a
Compare
@JounQin Thanks for resolving the Prettier problem. I see the following diff of the --- a/package-lock.json
+++ b/package-lock.json
@@ -89,6 +89,7 @@
"postcss-less": "^6.0.0",
"postcss-sass": "^0.5.0",
"postcss-scss": "^4.0.4",
+ "prettier": "2.7.1",
"remark-cli": "^11.0.0",
"sugarss": "^4.0.1",
"typescript": "^4.7.4" Could you fix the diff also, please? |
d0a871a
to
7944d0d
Compare
@ybiquitous Removed, although why it is added previously. 😂 |
I'm going to merge and wait for feedback from the other maintainers. |
Related #6282
No, it's self-explanatory.