fix: create new readers and writer for every async request #10026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleschoenburg
force-pushed
the
10014-create-reader-writers-on-request
branch
from
20b88d4
to
cade08f
Compare
oleschoenburg
force-pushed
the
10014-create-reader-writers-on-request
branch
from
cade08f
to
7feedba
Compare
oleschoenburg
commented
Aug 8, 2022
| super( | ||
| () -> requestReader, | ||
| () -> responseWriter, | ||
| new Supplier<>() { |
There was a problem hiding this comment.
💭 Looks weird but I found no other way to define a supplier that always returns the same instance of errorResponseWriter
There was a problem hiding this comment.
Sorry. Didn't see this comment before my review.
I think it is ok if it creates a new instance everytime.
deepthidevaki
approved these changes
Aug 8, 2022
Comment on lines
+33
to
+39
| new Supplier<>() { | ||
| private final ErrorResponseWriter errorResponseWriter = new ErrorResponseWriter(); | ||
|
|
||
| @Override | ||
| public ErrorResponseWriter get() { | ||
| return errorResponseWriter; | ||
| } |
There was a problem hiding this comment.
Suggested change
| new Supplier<>() { | |
| private final ErrorResponseWriter errorResponseWriter = new ErrorResponseWriter(); | |
| @Override | |
| public ErrorResponseWriter get() { | |
| return errorResponseWriter; | |
| } | |
| () -> new ErrorResponseWriter() |
Comment on lines
+94
to
+95
| final var responseWriter = responseWriterSupplier.get(); | ||
| final var errorResponseWriter = errorResponseWriterSupplier.get(); |
There was a problem hiding this comment.
💭 I still think you don't have to create these instances here. Instead it can be created in the implementation of handleAsync. But this is ok for now. We can discuss it when you refactor this class.
|
I'll merge this directly once jenkins runs through. |
10 tasks
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 9, 2022
10037: fix: create new readers and writer for every sync request r=oleschoenburg a=oleschoenburg ## Description Applies the fix in #10026 for sync api handlers too. Due to our actor scheduler, even sync handlers can't reuse readers andwriters because `onComplete` on the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10014 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 9, 2022
10037: fix: create new readers and writer for every sync request r=oleschoenburg a=oleschoenburg ## Description Applies the fix in #10026 for sync api handlers too. Due to our actor scheduler, even sync handlers can't reuse readers andwriters because `onComplete` on the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10014 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 9, 2022
10037: fix: create new readers and writer for every sync request r=oleschoenburg a=oleschoenburg ## Description Applies the fix in #10026 for sync api handlers too. Due to our actor scheduler, even sync handlers can't reuse readers andwriters because `onComplete` on the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10014 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows async api handlers to get new instances of request readers and writers on every request, while synchronous handlers can re-use their writers and readers.
Related issues
closes #10014
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.