Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Broker can handle admin request to pause exporting" #10025

Conversation

oleschoenburg
Copy link
Member

Reverts #9945 as a temporary workaround for #10014

@oleschoenburg oleschoenburg marked this pull request as ready for review August 8, 2022 10:34
@oleschoenburg
Copy link
Member Author

@deepthidevaki I think reverting this is okay because it's not yet used by anything, it unblocks other PRs that are failing CI due to #10014 and it gives me a little bit more time to fix #10014 properly.

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But not sure if you really have to revert this. I think it is easy to fix by changing the signature of handleAsync to not pass the responseWriter and errorWriter. Instead those are created inside handleAsync. But didn't look into it in detail. Reusing requestReader is probably ok.

I'm approving this anyway. So you can merge this if you think the above solution does not work or is too much work for a fast fix.

@oleschoenburg
Copy link
Member Author

👍 At first I didn't want to do this because that meant that the command api and others would also have to pay the cost of creating new readers and writers for every request but now I think I found a nice solution: #10026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants