fix: create new readers and writer for every sync request #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 811 files ± 0 811 suites ±0 1h 42m 17s ⏱️ - 1m 37s For more details on these failures, see this check. Results for commit caefea7. ± Comparison against base commit 7f1134c. ♻️ This comment has been updated with latest results. |
Due to our actor scheduler, even sync handlers can't reuse readers and writers because `onComplete` on the already completed future doesn't run immediately, causing a data race for concurrent requests.
lenaschoenburg
force-pushed
the
10014-create-readers-writes-on-sync-requests
branch
from
fbf6f7d
to
fab336e
Compare
This indirection was more confusing than helpful. All handlers are effectively async, even if their `handleAsync` implementation could be sync.
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 9, 2022
10037: fix: create new readers and writer for every sync request r=oleschoenburg a=oleschoenburg ## Description Applies the fix in #10026 for sync api handlers too. Due to our actor scheduler, even sync handlers can't reuse readers andwriters because `onComplete` on the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10014 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
runner crashed bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 9, 2022
10037: fix: create new readers and writer for every sync request r=oleschoenburg a=oleschoenburg ## Description Applies the fix in #10026 for sync api handlers too. Due to our actor scheduler, even sync handlers can't reuse readers andwriters because `onComplete` on the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10014 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
Ugh, bors r+ |
|
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
10014-create-readers-writes-on-sync-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies the fix in #10026 for sync api handlers too.
Due to our actor scheduler, even sync handlers can't reuse readers andwriters because
onCompleteon the already completed future doesn't run immediately, causing a data race on the readers and writers when handling concurrent requests.Related issues
closes #10014
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.