Fix return type issue in prepareVisitEventsStatement #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBAL\Connection::executeQuery has a return type of ResultStatement in ^2.8. Statement is a child class of ResultStatement in doctrine/dbal ^2.4. Forward compatibility layer of doctrine/dbal 2.13 changes return type of DBAL\Connection::executeQuery to ResultStatement&BaseResult which specifically removes execute method from the result statement. The method already executes the statement.
|
Thank you @pawelabrams! I am hopeful this will be fixed by doctrine/dbal#4596. |
|
Even after the Doctrine fix (which I also hope they will figure out), this proposal seems to fix the underlying typing issue. Are there any cases where the second |
pawelabrams
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBAL\Connection::executeQueryhas a return type ofResultStatementindoctrine/dbal ^2.8.Statement is a child class of
ResultStatementindoctrine/dbal ^2.4.Forward compatibility layer of
doctrine/dbal 2.13changes return type ofDBAL\Connection::executeQuerytoResultStatement&BaseResultwhich specifically removes execute method from the result statement.The method already executes the statement, so it is not needed explicitly in
visitEvents.