Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type issue in prepareVisitEventsStatement #41

Closed
wants to merge 2 commits into from
Closed

Fix return type issue in prepareVisitEventsStatement #41

wants to merge 2 commits into from

Commits on Apr 9, 2021

  1. Fix conflict with doctrine/dbal ^2.13 

    DBAL\Connection::executeQuery has a return type of ResultStatement in ^2.8.
Statement is a child class of ResultStatement in doctrine/dbal ^2.4.
Forward compatibility layer of doctrine/dbal 2.13 changes return type of DBAL\Connection::executeQuery to ResultStatement&BaseResult which specifically removes execute method from the result statement. The method already executes the statement.
    @pawelabrams
    pawelabrams committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    c1af2f0 View commit details
    Browse the repository at this point in the history

  2. Updated phpstan to not ignore the error.

    @pawelabrams
    pawelabrams committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    454913a View commit details
    Browse the repository at this point in the history