Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with doctrine/dbal ^2.13 #42

Closed
pawelabrams opened this issue Apr 13, 2021 · 1 comment
Closed

Conflict with doctrine/dbal ^2.13 #42

pawelabrams opened this issue Apr 13, 2021 · 1 comment
Labels

Comments

@pawelabrams
Copy link

Forward compatibility layer of doctrine/dbal 2.13 changes return type of DBAL\Connection::executeQuery to ResultStatement&BaseResult which specifically removes execute method from the result statement. Furthermore, it causes one of the phpstan errors set to be ignored in commit d6be1be .

DBAL\Connection::executeQuery has a return type of ResultStatement since doctrine/dbal 2.8.
Statement is a child class of ResultStatement since doctrine/dbal 2.4, therefore not causing a problem in any supported versions of this dependency.

Furthermore, the executeQuery method already executes the statement, so it is not needed explicitly in visitEvents.

I have proposed a pull request to amend these issues and drop ignoring of the problem in phpstan in #41 .

@stale
Copy link

stale bot commented May 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 15, 2021
@stale stale bot closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant