You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forward compatibility layer of doctrine/dbal 2.13 changes return type of DBAL\Connection::executeQuery to ResultStatement&BaseResult which specifically removes execute method from the result statement. Furthermore, it causes one of the phpstan errors set to be ignored in commit d6be1be .
DBAL\Connection::executeQuery has a return type of ResultStatement since doctrine/dbal 2.8.
Statement is a child class of ResultStatement since doctrine/dbal 2.4, therefore not causing a problem in any supported versions of this dependency.
Furthermore, the executeQuery method already executes the statement, so it is not needed explicitly in visitEvents.
I have proposed a pull request to amend these issues and drop ignoring of the problem in phpstan in #41 .
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Forward compatibility layer of
doctrine/dbal 2.13
changes return type ofDBAL\Connection::executeQuery
toResultStatement&BaseResult
which specifically removesexecute
method from the result statement. Furthermore, it causes one of the phpstan errors set to be ignored in commit d6be1be .DBAL\Connection::executeQuery
has a return type ofResultStatement
sincedoctrine/dbal 2.8
.Statement is a child class of ResultStatement since
doctrine/dbal 2.4
, therefore not causing a problem in any supported versions of this dependency.Furthermore, the
executeQuery
method already executes the statement, so it is not needed explicitly invisitEvents
.I have proposed a pull request to amend these issues and drop ignoring of the problem in phpstan in #41 .
The text was updated successfully, but these errors were encountered: