Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin specific patch version for pypi upload action #12

Merged
merged 1 commit into from Feb 1, 2024

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Feb 1, 2024

Because that action doesn't support specifying e.g. v1 or v1.8, we have to be specific - in this case v1.8.11 (the alternative is to depend on main/master).

See pypa/gh-action-pypi-publish#22

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17ac709) 0.00% compared to head (fa776df) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #12   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          5       5           
=====================================
  Misses         5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi merged commit 1663b1a into main Feb 1, 2024
22 checks passed
@niksirbi niksirbi deleted the niksirbi-patch-1 branch February 1, 2024 10:27
niksirbi pushed a commit to neuroinformatics-unit/actions that referenced this pull request Feb 1, 2024
* Update pypi publishing action to latest patch

See
- brainglobe/brainglobe-template-builder#11
- brainglobe/brainglobe-template-builder#12

* bump pypi action version to 1.8.11 in example workflow
niksirbi added a commit to neuroinformatics-unit/actions that referenced this pull request Feb 1, 2024
* Bump action versions in upload_pypi

* Update example_test_and_deploy.yml with new upload action versions

* pin specific version of pypa upload action

* Update pypi publishing action to latest patch (#39)

* Update pypi publishing action to latest patch

See
- brainglobe/brainglobe-template-builder#11
- brainglobe/brainglobe-template-builder#12

* bump pypi action version to 1.8.11 in example workflow

---------

Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant