Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pypi publishing action to latest patch #39

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Bumping our versions through depandabot exposed a few minor issues in our actions setup
See

What does this PR do?
Fix the pypi upload action to use the latest version and update the example workflow to actually use the upload action

References

How has this PR been tested?

See above PRs to brainglobe-template-builder which served as a test.

Is this a breaking change?

May cause failures in repos using our actions (but hopefully not). This was announced on NIU slack and BrainGlobe zulip.

Does this PR require an update to the documentation?

Nope

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@niksirbi niksirbi merged commit 7a42fea into bump-upload-pypi Feb 1, 2024
niksirbi added a commit that referenced this pull request Feb 1, 2024
* Bump action versions in upload_pypi

* Update example_test_and_deploy.yml with new upload action versions

* pin specific version of pypa upload action

* Update pypi publishing action to latest patch (#39)

* Update pypi publishing action to latest patch

See
- brainglobe/brainglobe-template-builder#11
- brainglobe/brainglobe-template-builder#12

* bump pypi action version to 1.8.11 in example workflow

---------

Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants