Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump action versions in upload_pypi #38

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Bump action versions in upload_pypi #38

merged 4 commits into from
Feb 1, 2024

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Jan 31, 2024

No idea why dependabot didn't update actions/download-artifact from v3 to v4, but it's critical that we do it, because it has to match the major version of actions/upload-artifact, which was bumped to v4` by the bot.

Bumping our versions through depandabot exposed a few other minor issues in our actions setup, related to the pypi upload action, see:

for our debugging experiments.

In this PR we also fix the pypi upload action to use the latest version (pinning to 1.8.11)

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 🤞

niksirbi and others added 2 commits February 1, 2024 10:32
@niksirbi niksirbi marked this pull request as ready for review February 1, 2024 10:39
@niksirbi niksirbi merged commit 334d8a3 into main Feb 1, 2024
@niksirbi niksirbi deleted the bump-upload-pypi branch February 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants