Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace numpy.bool8 with numpy.bool_ #12690

Merged
merged 1 commit into from Dec 21, 2022
Merged

Conversation

mrocklin
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #12690 (6df57b7) into branch-3.1 (cddffd5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           branch-3.1   #12690      +/-   ##
==============================================
- Coverage       86.54%   86.54%   -0.01%     
==============================================
  Files             338      339       +1     
  Lines           20890    20892       +2     
==============================================
  Hits            18080    18080              
- Misses           2810     2812       +2     

@mattpap mattpap added this to the 3.1 milestone Dec 20, 2022
@mattpap mattpap merged commit 3b19634 into bokeh:branch-3.1 Dec 21, 2022
@mattpap
Copy link
Contributor

mattpap commented Dec 21, 2022

@mrocklin, thanks.

@bnavigator
Copy link
Contributor

Just a note that this does not fix dask until dask supports bokeh 3
dask/distributed#7327
dask/dask#9673
dask/distributed#7329

@bryevdv
Copy link
Member

bryevdv commented Jan 4, 2023

I'm not sure I understand, all of the technical issues that were brought to our attention were resolved in Bokeh 3.0.3.

@bnavigator
Copy link
Contributor

bnavigator commented Jan 4, 2023

dask and distributed still pin to bokeh <3. This fix is only for bokeh >= 3.1

That's all I am saying.

@bryevdv
Copy link
Member

bryevdv commented Jan 4, 2023

This fix is not required for Dask to function, AFAIK it is merely to clear a deprecation warning in Dask CI? Bokeh 3.1 or 3.0.4 will be released soon in any case, but Dask could lift that version limit to 3.0.3 any time as far as I know.

@mrocklin
Copy link
Contributor Author

mrocklin commented Jan 4, 2023

This fix is not required for Dask to function, AFAIK it is merely to clear a deprecation warning in Dask CI? Bokeh 3.1 or 3.0.4 will be released soon in any case, but Dask could lift that version limit to 3.0.3 any time as far as I know.

Yup

@mrocklin mrocklin deleted the bool8-bool_ branch January 4, 2023 16:14
bryevdv pushed a commit that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants