New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace numpy.bool8 with numpy.bool_ #12690
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.1 #12690 +/- ##
==============================================
- Coverage 86.54% 86.54% -0.01%
==============================================
Files 338 339 +1
Lines 20890 20892 +2
==============================================
Hits 18080 18080
- Misses 2810 2812 +2 |
@mrocklin, thanks. |
Just a note that this does not fix dask until dask supports bokeh 3 |
I'm not sure I understand, all of the technical issues that were brought to our attention were resolved in Bokeh 3.0.3. |
dask and distributed still pin to bokeh <3. This fix is only for bokeh >= 3.1 That's all I am saying. |
This fix is not required for Dask to function, AFAIK it is merely to clear a deprecation warning in Dask CI? Bokeh 3.1 or 3.0.4 will be released soon in any case, but Dask could lift that version limit to 3.0.3 any time as far as I know. |
Yup |
Fixes #12689
Fixes dask/distributed#7422