Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace numpy.bool8 with numpy.bool_ #12690

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Replace numpy.bool8 with numpy.bool_ #12690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bokeh/core/property/primitive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
# Globals and constants
#-----------------------------------------------------------------------------

bokeh_bool_types = (bool, np.bool8)
bokeh_bool_types = (bool, np.bool_)
bokeh_integer_types = (numbers.Integral,)

__all__ = (
Expand Down
16 changes: 8 additions & 8 deletions tests/unit/bokeh/core/property/test_primitive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def test_valid(self) -> None:
assert prop.is_valid(False)
assert prop.is_valid(True)

assert prop.is_valid(np.bool8(False))
assert prop.is_valid(np.bool8(True))
assert prop.is_valid(np.bool_(False))
assert prop.is_valid(np.bool_(True))

def test_invalid(self) -> None:
prop = bcpp.Bool()
Expand Down Expand Up @@ -167,8 +167,8 @@ def test_invalid(self) -> None:
assert not prop.is_valid(_TestHasProps())
assert not prop.is_valid(_TestModel())

assert not prop.is_valid(np.bool8(False))
assert not prop.is_valid(np.bool8(True))
assert not prop.is_valid(np.bool_(False))
assert not prop.is_valid(np.bool_(True))

def test_has_ref(self) -> None:
prop = bcpp.Complex()
Expand Down Expand Up @@ -227,8 +227,8 @@ def test_invalid(self) -> None:
assert not prop.is_valid(_TestHasProps())
assert not prop.is_valid(_TestModel())

assert not prop.is_valid(np.bool8(False))
assert not prop.is_valid(np.bool8(True))
assert not prop.is_valid(np.bool_(False))
assert not prop.is_valid(np.bool_(True))
assert not prop.is_valid(np.complex64(1.0+1.0j))
assert not prop.is_valid(np.complex128(1.0+1.0j))
if hasattr(np, "complex256"):
Expand Down Expand Up @@ -359,8 +359,8 @@ def test_invalid(self) -> None:
assert not prop.is_valid(_TestHasProps())
assert not prop.is_valid(_TestModel())

assert not prop.is_valid(np.bool8(False))
assert not prop.is_valid(np.bool8(True))
assert not prop.is_valid(np.bool_(False))
assert not prop.is_valid(np.bool_(True))
assert not prop.is_valid(np.float16(0))
assert not prop.is_valid(np.float16(1))
assert not prop.is_valid(np.float32(0))
Expand Down