Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 3.0.4 [DO NOT MERGE] #12833

Closed
wants to merge 44 commits into from
Closed

Conversation

bryevdv
Copy link
Member

@bryevdv bryevdv commented Feb 22, 2023

For consideration to even out our release branches, which are getting lopsided even while there are 50 open issues in the milestone.

This is a collections of docs, infra, and bugfixes backported from branch-3.1. The PR itself is large due to

  • copyright updates
  • chrome issue update

We could potentially remove the latter depending on folks comfort levels.

bryevdv and others added 30 commits February 21, 2023 15:21
* Allow Datetime in BoxAnnotation

* Update geometry.py

* add FloatOrDatetime type as alias for Datetime

* adapt examples

* remove FloatOrDatetime and add CoordinateLike

* adapt annotation tests

* remove unnecessary imports

* adjust style in tests

* rename combiend.py to aliases.py

* import CorrdinateLike in properties.py
* Add text_outline_color to documentation

Support for ``text_outline_color`` was added in #12287 but this was not yet added to the documentation.

* Remove trailing whitespace

* Remove trailing whitespace
* Don't allow hover tool's tooltips to show outside the frame

* Add visual regression tests
* Use circle centers for rect/poly hit testing

Also fixes indexing in poly hit testing and allows to use
spatial index.

* Reduce code duplication in circle.ts

* Simplify color mapping integration tests

* Update image baseline

* Add visual regression tests
* Add missing tooltipps section

* Explain example JS output

* Add link for SetValue

* Fix typo in ref guide

* Fix typo

Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>

Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
Ref. #2367.

That the glyphs for `nonselection_glyph` and `hover_glyph` is not affected by size, etc. bit me in the back, and apparently has confused many others as well, judging from the issue tracker. I think this behaviour is very unexpected, and deserves a warning level note.

Also, I think it would be great to be more explicit about what *visual* properties are, or link to where to find that. For me, it is for example not obvious that size is not a visual property. I would love to to it myself, but I am not familiar enough with Bokeh to do that.
* Update Apache load balancing section

Change the load balancing method to 'bybusyness' and add brief description

* Minor changes to Apache load balancing docs

Mention alternative algorithms, add link to Apache docs and reduce line length
* Move _qbb and _cbb to core/util/math

* Improve implementation and return types of qbb/cbb

* Move qbb/cbb to avoid cyclic module dependencies

* Return ordered values from cbb()

* Correctly allocate array for bounds

* Correctly interpret arguments to cbb()

* Add unit tests for qbb() and cbb()

* Update visual baselines
* Added metadata to examples

* Removed trailing whitespaces

* Update examples/basic/lines/line_single.py

---------

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
* Add tag instruction to dev setup

* Fix typo

* Make adding/fetching upstream unconditional

* Fix indentation error
mattpap and others added 13 commits February 21, 2023 15:41
* Better handling of shape in ObjectNDArray

* Allow to mix arrays and ndarrays in streaming
* added meta data for custom_tooltip.py

* added metadata to custom_tooltip.py and corrections to pass tests

* trying to detect which modules are failing tests

* removed trailing whitespace

* fixed indentation error in test file

* fixed indentation error in test file

* corrected an import error

* still trying to pass tests

* changed sphinxext to sphinx

* Update examples/plotting/custom_tooltip.py

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>

* Update examples/plotting/custom_tooltip.py

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>

* Update examples/plotting/custom_tooltip.py

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>

---------

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
* Flush only actually synced references

* Make tests adhere to the protocol

* Flush new models after applying a patch
* Do not use inefficient select() when adding legend

* Fix typo in test filename (lengends -> legends)

* Add unit tests for Legend._get_or_create_legend
* Test all components are bundled if no objs given

* Reuse object traversal result when bundling

This replaces 9 calls to Model.references() with a single one, reducing
the time it takes to create a plot and write out the HTML by about 46%.
* Set event loop for IOLoop to use

* Sort imports
Added metadata to hover.py
Partially addresses issue #11765 #11765
* Document Rect glyph shouldn't be used on log axes

* Clarify that x and y are centre position

* Add warning to figure.rect
* Activate bugbear checks in ruff

* Individually exclude currently-failing ruff "B" checks
* Update first_steps_2_add_circles.py

* Update first_steps_2_add_circles.py
* Resolve issues with headless Chromium 110

* Update baseline images

* Update baseline files

* Require Chromium 110+ for testing

* Robustify a unit test involving clipboard
* Completely reset ctx transform when drawing patterns

* Update visual baselines

* Add visual regression tests
* Fix svg rotated ellipses

* Use AffineTransform
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #12833 (40c4753) into branch-3.0 (9f00012) will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           branch-3.0   #12833      +/-   ##
==============================================
+ Coverage       92.12%   92.14%   +0.02%     
==============================================
  Files             312      313       +1     
  Lines           19558    19590      +32     
==============================================
+ Hits            18018    18052      +34     
+ Misses           1540     1538       -2     

@bryevdv
Copy link
Member Author

bryevdv commented Feb 22, 2023

Some notes:

  • there are three failing JS tests, it would be good to understand those

  • there are at least some failing examples, but they are also failing in branch-3.1

    Screenshot 2023-02-21 at 20 24 40
  • almost all the currently skipped integration tests also pass

  • whatever broke custom extensions for Safari seems to be included in this batch

@bryevdv bryevdv closed this Feb 24, 2023
@bryevdv bryevdv deleted the bv/backports-for-3.0.4 branch March 12, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet