Resolve circular dependency #3054
Comments
This seems to be a recently reported issue to the I don't think it's because the dependency is circular; I think it's the versions. |
I found that to bump styled-components to 5.0.0, we have to bump jest-styled-components to 7.0.0 It's also important to modify the package-lock.json in root to specify |
|
It seems like this is still an issue. Still blocked pending this being fixed in jest-styled-components: styled-components/jest-styled-components#297 |
We've started tackling this as part of bbc/simorgh#6922 and bbc/simorgh#5182 with the merge of #3636 and #3638. |
Describe the bug
Related to bbc/simorgh#5182
The latest update of
jest-styled-components
requiresstyled-components
as a peerDependency, addingstyled-components
insidepsammead-test-helpers
causes a test failure.Bumping of
styled-components
in the rootpackage.json
resolves the test failure above, but produces new test failures, this is becausepsammead-test-helpers
is used throughout psammead.To Reproduce
Steps to reproduce the behaviour:
psammead-test-helpers
and openpackage.json
jest-styled-components
and addstyled-components
as a peerDependency.npm install
insidepackages/utilities/psammead-test-helpers
package.json
styled-components
to5.0.0
npm install
Expected behaviour
No errors.
We should not have to publish a failing package.
Screenshots
Bumping
jest-styled-components
and addingstyled-components
as a peerDependency inpsammead-test-helpers
.Bumping
styled-components
in rootpackage.json
.Testing notes
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: