Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Styled Components v5 #5182

Closed
1 task
simonsinclair opened this issue Jan 18, 2020 · 2 comments
Closed
1 task

Upgrade to Styled Components v5 #5182

simonsinclair opened this issue Jan 18, 2020 · 2 comments
Assignees
@simonsinclair
Labels
performance technical-work Technical debt, support work and building new technical tools and features ws-articles Tasks for the WS Articles Team
Projects
Simorgh

Comments

@simonsinclair
Copy link
Contributor

simonsinclair commented Jan 18, 2020 •
edited

Is your feature request related to a problem? Please describe.
Upgrade to the latest release of Styled Components v5. It is non-breaking and compared to v4, it comes with:

  • 26% smaller bundle size (16.2kB vs. 12.42kB min+gzip)
  • 22% faster client-side mounting
  • 26% faster updating of dynamic styles
  • 45% faster server-side rendering

Describe the solution you'd like

Simorgh:

  • Update styled-components to the latest version.
  • Update jest-styled-components to the latest version.
  • Check for regressions.

Psammead:

  • Update styled-components to the latest version.
  • Update jest-styled-components to the latest version.
  • Update psammead-test-helpers to use the latest jest-styled-components.
  • Check for regressions.

Describe alternatives you've considered
n/a

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
@simonsinclair simonsinclair added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. performance labels Jan 18, 2020
@simonsinclair simonsinclair added this to To do in Simorgh via automation Jan 18, 2020
@simonsinclair simonsinclair self-assigned this Jan 20, 2020
@simonsinclair simonsinclair moved this from To do to Issue in Progress in Simorgh Jan 20, 2020
@simonsinclair simonsinclair removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jan 20, 2020
@DenisHdz DenisHdz mentioned this issue Jan 20, 2020
Closed
3 tasks
@12 12 added the tech-debt label Jan 23, 2020
@FK78 FK78 mentioned this issue Jan 24, 2020
Merged
3 tasks
@DenisHdz DenisHdz mentioned this issue Jan 24, 2020
Closed
3 tasks
@FK78 FK78 mentioned this issue Feb 4, 2020
Closed
1 task
@joshcoventry joshcoventry added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jun 23, 2020
@joshcoventry
Copy link
Contributor

Blocked by bbc/psammead#3054

@joshcoventry joshcoventry moved this from Issue in Progress to To do in Simorgh Jun 23, 2020
@karinathomasbbc karinathomasbbc added technical-work Technical debt, support work and building new technical tools and features and removed tech-debt labels Jul 21, 2020
This was referenced Jul 29, 2020
Merged
Merged
@simonsinclair simonsinclair added ws-articles Tasks for the WS Articles Team and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Jul 29, 2020
@simonsinclair simonsinclair added this to Issue in Progress in Simorgh Jul 29, 2020
@simonsinclair simonsinclair mentioned this issue Jul 30, 2020
Merged
6 tasks
@simonsinclair
Copy link
Contributor Author

Closing in favour of migrating to Emotion, which is tracked in the following issue: #7772.

Simorgh automation moved this from Issue in Progress to Done Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonsinclair simonsinclair

Labels
performance technical-work Technical debt, support work and building new technical tools and features ws-articles Tasks for the WS Articles Team
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Styled Components to v5 bbc/psammead
5 participants
@simonsinclair @12 @DenisHdz @karinathomasbbc @joshcoventry