Bump styled components #3180
Bump styled components #3180
Conversation
- bump jest-styled-components from ^6.3.3 to ^7.0.0 - bump styled-components from ^4.4.1 to ^5.0.0
mykeels
added
ws-home
for psammead-test-helpers
… bump-styled-components
| @@ -538,53 +562,47 @@ exports[`Grid component should render Grid with Grid items including nested non- | |||
| @media (max-width:14.9375rem) { | |||
| .c1 { | |||
| width: calc(100% - 0%); | |||
| margin-left: 0%; | |||
| display: inline-block; | |||
| margin-left: 0% display:inline-block; | |||
There was a problem hiding this comment.
Please can we verify this syntax? It looks invalid.
| @media (max-width:14.9375rem) { | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
I'm seeing lots of additions in snapshots like this. Please can we confirm why they're appearing?
| <style | ||
| data-styled="active" | ||
| data-styled-version="5.0.1" | ||
| /> |
There was a problem hiding this comment.
I'm curious what this does - please can we confirm?
| @@ -27,7 +27,8 @@ | |||
| "snapshot" | |||
| ], | |||
| "dependencies": { | |||
| "jest-styled-components": "^6.3.3" | |||
| "jest-styled-components": "^7.0.0", | |||
| "styled-components": "^5.0.0" | |||
There was a problem hiding this comment.
It looks like a new dependency on styled-components has been added here. Please can you confirm why this has been added, when psammead-test-helpers doesn't use it directly? If it's because jest-styled-components complains, can it be a peer dependency?
| @@ -3,6 +3,7 @@ | |||
| <!-- prettier-ignore --> | |||
| | Version | Description | | |||
| |---------|-------------| | |||
| | 4.0.0 | [PR#3180](https://github.com/bbc/psammead/pull/3180) Bump styled components | | |||
There was a problem hiding this comment.
This change bumps jest-styled-components and adds styled-components as a dependency. This line should probably reflect that.
|
The snapshot issues are covered in this open issue. |
|
Closing this for now, waiting updates on jest styled components |
Resolves #3054
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes:
^5.0.0.^7.0.0.