This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
[1/2] Decouple jest-styled-components from psammead-test-helpers #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsinclair
added
ws-articles
simonsinclair
changed the title
simonsinclair
changed the title
simonsinclair
changed the title
simonsinclair
added a commit
that referenced
this pull request
Jul 29, 2020
2 tasks
simonsinclair
changed the title
This was referenced Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue.
Overall change:
This PR is a part of a series working towards improving SSR performance – starting by upgrading to Styled Components v5.
It decouples
jest-styled-componentsfrompsammead-test-helpers, so that it can be reinstated in the recommended way - injest.config.jsin both Psammead and Simorgh. This will happen in a follow-up PR.Aside
This will afford us more control over our testing configuration and help us work towards resolving long-unsolved issues:
[ ] This PR requires manual testing