Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Node.js versions to 16 & 18 #12558

Merged
merged 22 commits into from Nov 7, 2022
Merged

Switch Node.js versions to 16 & 18 #12558

merged 22 commits into from Nov 7, 2022

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Jul 9, 2022

Time to move Node.js support from 14 & 16 to 16 & 18. Along with that we can bump the ECMAScript target to ES2021

@Rugvip Rugvip requested review from a team as code owners July 9, 2022 14:42
@github-actions github-actions bot added documentation Improvements or additions to documentation area:scaffolder Everything and all things related to the scaffolder project area labels Jul 9, 2022
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the auth label Jul 11, 2022
@Rugvip Rugvip mentioned this pull request Jul 11, 2022
Merged
@Rugvip
Copy link
Member Author

Rugvip commented Jul 12, 2022 •
edited

This is blocked by the release of kubernetes-client/javascript#837 (kubernetes-client/javascript#867) right now, since we can't work around the transitive dependency on openid-client in a clean way.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

@github-actions github-actions bot added the stale label Jul 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

@github-actions github-actions bot added the stale label Aug 2, 2022
@benjdlambert
Copy link
Member

We're waiting for a release of the @kubernetes/client-node package if I remember correctly, but it's not released yet.

@github-actions github-actions bot removed the stale label Aug 2, 2022
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

@github-actions github-actions bot added the stale label Aug 14, 2022
@Rugvip Rugvip removed the stale label Aug 17, 2022
@Rugvip Rugvip mentioned this pull request Aug 19, 2022
Closed
5 tasks
@Rugvip Rugvip force-pushed the rugvip/node18 branch 2 times, most recently from f84fb68 to 901a7c7 Compare August 19, 2022 09:38
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

@github-actions github-actions bot added the stale label Aug 26, 2022
@github-actions github-actions bot closed this Aug 31, 2022
@Rugvip Rugvip reopened this Aug 31, 2022
@Rugvip Rugvip removed the stale label Aug 31, 2022
@Rugvip Rugvip mentioned this pull request Nov 3, 2022
Merged
@Rugvip Rugvip assigned freben and unassigned benjdlambert Nov 3, 2022
Rugvip and others added 22 commits November 7, 2022 11:39
@Rugvip
bump Node.js to 16 & 18
7605c11 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
changests: add changesets for Node.js 18 bump
384eaa2 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip @benjdlambert
auth-backend: add script for re-publishing openid-client
1d43bcf 
Co-authored-by: blam <ben@blam.sh>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip @benjdlambert
auth-backend: use openid-client-any-engine
4ca99cc 
Co-authored-by: blam <ben@blam.sh>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
root: add node-gyp dep to fill missing dep of ssh2
009db8b 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
root: work around openid-client with resolutions
24b06ff 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
scripts/check-type-dependencies: work around exports resolution
6fb165f 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
bump @kubernetes/client-node to 0.17.1
cfb30b7 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
workflows: work around missing node-canvas binaries for node 18
7bcb96a 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
backend-common: work around premature close errors
21339ea 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
catalog-backend-module-github: work around lack of msw fetch support …
90e5b42 
…in Node 18

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
Revert "root: work around openid-client with resolutions"
428e5d5 
This reverts commit 59bcd77.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
Revert "auth-backend: use openid-client-any-engine"
40c578e 
This reverts commit fabe460.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
Revert "auth-backend: add script for re-publishing openid-client"
442cbba 
This reverts commit 6c7a73e.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
pin @kubernetes/client-node to working version
2008aec 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
auth-backend: bump openid-client to most recent version
ee35a69 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
Revert "workflows: work around missing node-canvas binaries for node 18"
a8dac60 
This reverts commit 0ab2705.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
Revert "backend-common: work around premature close errors"
93554b0 
This reverts commit b29587c.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
bump canvas to 2.10.2
e92aa15 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
bump tar to 6.1.12
88f99b8 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
e2e-test: add wait before checking backend availability
f121e3f 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
create-app: fix default backend listen config and comments
864c876 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
freben
freben approved these changes Nov 7, 2022
View reviewed changes
plugins/scaffolder-backend/scripts/build-nunjucks.js
@@ -58,7 +58,7 @@ require('esbuild')
bundle: true,
format: 'cjs',
platform: 'node',
target: 'node14',
target: 'node16',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you actually perform a rebuild too, but nothing changed?

packages/cli/config/tsconfig.json
@@ -32,7 +32,7 @@
"strictNullChecks": true,
"strictPropertyInitialization": true,
"stripInternal": true,
"target": "ES2019",
"target": "ES2021",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmmm, all of the ??= and stuff, right? :)

@Rugvip Rugvip merged commit dbf618b into master Nov 7, 2022
@Rugvip Rugvip deleted the rugvip/node18 branch November 7, 2022 12:41
@awanlin awanlin mentioned this pull request Nov 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

@camilaibs camilaibs camilaibs approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Assignees

@freben freben

Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area auth documentation Improvements or additions to documentation will-fix We will fix this at some point
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rugvip @benjdlambert @webark @freben @camilaibs